From 300c3970f3b81d064d3c018f742c474a5b608de5 Mon Sep 17 00:00:00 2001 From: spycrab Date: Fri, 4 May 2018 13:51:55 +0200 Subject: [PATCH] Qt/GraphicsControls: Fix more random crashes --- Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp | 3 +++ Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp | 3 +++ Source/Core/DolphinQt2/Config/Graphics/GraphicsRadio.cpp | 3 +++ 3 files changed, 9 insertions(+) diff --git a/Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp b/Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp index 1285909474..86e7b62861 100644 --- a/Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp +++ b/Source/Core/DolphinQt2/Config/Graphics/GraphicsBool.cpp @@ -20,7 +20,10 @@ GraphicsBool::GraphicsBool(const QString& label, const Config::ConfigInfo& QFont bf = font(); bf.setBold(Config::GetActiveLayerForConfig(m_setting) != Config::LayerType::Base); setFont(bf); + + bool old = blockSignals(true); setChecked(Config::Get(m_setting) ^ m_reverse); + blockSignals(old); }); } diff --git a/Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp b/Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp index 3df59a38c6..4e7c95ed41 100644 --- a/Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp +++ b/Source/Core/DolphinQt2/Config/Graphics/GraphicsChoice.cpp @@ -19,7 +19,10 @@ GraphicsChoice::GraphicsChoice(const QStringList& options, const Config::ConfigI QFont bf = font(); bf.setBold(Config::GetActiveLayerForConfig(m_setting) != Config::LayerType::Base); setFont(bf); + + bool old = blockSignals(true); setCurrentIndex(Config::Get(m_setting)); + blockSignals(old); }); } diff --git a/Source/Core/DolphinQt2/Config/Graphics/GraphicsRadio.cpp b/Source/Core/DolphinQt2/Config/Graphics/GraphicsRadio.cpp index f2bf063322..094d1f941b 100644 --- a/Source/Core/DolphinQt2/Config/Graphics/GraphicsRadio.cpp +++ b/Source/Core/DolphinQt2/Config/Graphics/GraphicsRadio.cpp @@ -18,7 +18,10 @@ GraphicsRadioInt::GraphicsRadioInt(const QString& label, const Config::ConfigInf QFont bf = font(); bf.setBold(Config::GetActiveLayerForConfig(m_setting) != Config::LayerType::Base); setFont(bf); + + bool old = blockSignals(true); setChecked(Config::Get(m_setting) == m_value); + blockSignals(old); }); }