mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-11 00:40:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Common/x64Emitter: Resolve TODO in OpArg's operator==

Browse Source 
We now require C++17, so we can use std::tie here.
This commit is contained in:
Lioncash 2019-05-30 10:27:26 -04:00
parent 00ecfb3c59
commit 66596c5176
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/Common/x64Emitter.h
View File

@ -120,10 +120,8 @@ struct OpArg
} }
constexpr bool operator==(const OpArg& b) const constexpr bool operator==(const OpArg& b) const
{ {
// TODO: Use std::tie here once Dolphin requires C++17. (We can't do it immediately, return std::tie(scale, offsetOrBaseReg, indexReg, offset, operandReg) ==
// (because we still support some older versions of GCC where std::tie is not constexpr.) std::tie(b.scale, b.offsetOrBaseReg, b.indexReg, b.offset, b.operandReg);
return operandReg == b.operandReg && scale == b.scale && offsetOrBaseReg == b.offsetOrBaseReg &&
indexReg == b.indexReg && offset == b.offset;
} }
constexpr bool operator!=(const OpArg& b) const { return !operator==(b); } constexpr bool operator!=(const OpArg& b) const { return !operator==(b); }
u64 Imm64() const u64 Imm64() const