diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java index 2e297050ee..837024c2ab 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java @@ -111,16 +111,13 @@ public final class SettingsActivity extends AppCompatActivity implements Setting mPresenter.onStop(isFinishing()); } - @Override - public void onBackPressed() - { - mPresenter.onBackPressed(); - } - @Override public void showSettingsFragment(MenuTag menuTag, Bundle extras, boolean addToStack, String gameID) { + if (!addToStack && getFragment() != null) + return; + FragmentTransaction transaction = getSupportFragmentManager().beginTransaction(); if (addToStack) @@ -135,7 +132,6 @@ public final class SettingsActivity extends AppCompatActivity implements Setting } transaction.addToBackStack(null); - mPresenter.addToStack(); } transaction.replace(R.id.frame_content, SettingsFragment.newInstance(menuTag, gameID, extras), FRAGMENT_TAG); @@ -277,12 +273,6 @@ public final class SettingsActivity extends AppCompatActivity implements Setting Toast.makeText(this, message, Toast.LENGTH_SHORT).show(); } - @Override - public void popBackStack() - { - getSupportFragmentManager().popBackStackImmediate(); - } - @Override public void onSettingChanged(String key) { diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java index 34e8ba2a10..3072333f5d 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java @@ -23,8 +23,6 @@ public final class SettingsActivityPresenter private Settings mSettings; - private int mStackCount; - private boolean mShouldSave; private DirectoryStateReceiver directoryStateReceiver; @@ -43,16 +41,11 @@ public final class SettingsActivityPresenter public void onCreate(Bundle savedInstanceState, MenuTag menuTag, String gameId, Context context) { - if (savedInstanceState == null) - { - this.menuTag = menuTag; - this.gameId = gameId; - this.context = context; - } - else - { - mShouldSave = savedInstanceState.getBoolean(KEY_SHOULD_SAVE); - } + this.menuTag = menuTag; + this.gameId = gameId; + this.context = context; + + mShouldSave = savedInstanceState != null && savedInstanceState.getBoolean(KEY_SHOULD_SAVE); } public void onStart() @@ -148,24 +141,6 @@ public final class SettingsActivityPresenter } } - public void addToStack() - { - mStackCount++; - } - - public void onBackPressed() - { - if (mStackCount > 0) - { - mView.popBackStack(); - mStackCount--; - } - else - { - mView.finish(); - } - } - public boolean handleOptionsItem(int itemId) { switch (itemId) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityView.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityView.java index 266cb499bb..1507706e0f 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityView.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityView.java @@ -47,11 +47,6 @@ public interface SettingsActivityView */ void showToastMessage(String message); - /** - * Show the previous fragment. - */ - void popBackStack(); - /** * End the activity. */