From 52eb2d0d826fddd2c0248ad753ee629419277936 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 27 May 2019 10:19:49 -0400 Subject: [PATCH] DiscIO/VolumeVerifier: Default destructor within the cpp file Given the volume verifier has quite a few non-trivial object within it, it's best to default the destructor within the cpp file to prevent inlining complex destruction logic elsewhere, while also making it nicer if a forward-declared type is ever used in a member variable. --- Source/Core/DiscIO/VolumeVerifier.cpp | 2 ++ Source/Core/DiscIO/VolumeVerifier.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Source/Core/DiscIO/VolumeVerifier.cpp b/Source/Core/DiscIO/VolumeVerifier.cpp index 39061283da..653cbbaf9c 100644 --- a/Source/Core/DiscIO/VolumeVerifier.cpp +++ b/Source/Core/DiscIO/VolumeVerifier.cpp @@ -54,6 +54,8 @@ VolumeVerifier::VolumeVerifier(const Volume& volume, Hashes hashes_to_calc { } +VolumeVerifier::~VolumeVerifier() = default; + void VolumeVerifier::Start() { ASSERT(!m_started); diff --git a/Source/Core/DiscIO/VolumeVerifier.h b/Source/Core/DiscIO/VolumeVerifier.h index e8c68ef26f..4c2be055d1 100644 --- a/Source/Core/DiscIO/VolumeVerifier.h +++ b/Source/Core/DiscIO/VolumeVerifier.h @@ -72,6 +72,8 @@ public: }; VolumeVerifier(const Volume& volume, Hashes hashes_to_calculate); + ~VolumeVerifier(); + void Start(); void Process(); u64 GetBytesProcessed() const;