From 9feb18866b42007212f4e6961b56c0b4df5c29a9 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 27 Mar 2018 12:04:10 -0400 Subject: [PATCH] BPStructs: Remove an unnecessary pointer cast in GetBPRegInfo swap32 has an overload that accepts a u8*, performing the same behavior in a well-defined manner. --- Source/Core/VideoCommon/BPStructs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/VideoCommon/BPStructs.cpp b/Source/Core/VideoCommon/BPStructs.cpp index 6a78dc6dd7..0078633b08 100644 --- a/Source/Core/VideoCommon/BPStructs.cpp +++ b/Source/Core/VideoCommon/BPStructs.cpp @@ -718,7 +718,7 @@ void GetBPRegInfo(const u8* data, std::string* name, std::string* desc) const char* no_yes[2] = {"No", "Yes"}; u8 cmd = data[0]; - u32 cmddata = Common::swap32(*(u32*)data) & 0xFFFFFF; + u32 cmddata = Common::swap32(data) & 0xFFFFFF; switch (cmd) { // Macro to set the register name and make sure it was written correctly via compile time assertion