From 394418b41540ddb1b2d089066a092a5169739416 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 31 Jan 2024 22:01:43 -0500 Subject: [PATCH] AchievementManager: Remove unnecessary .get() Same behavior, less code. --- Source/Core/Core/AchievementManager.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Source/Core/Core/AchievementManager.cpp b/Source/Core/Core/AchievementManager.cpp index d43e5922f3..10a11e693f 100644 --- a/Source/Core/Core/AchievementManager.cpp +++ b/Source/Core/Core/AchievementManager.cpp @@ -178,16 +178,13 @@ void AchievementManager::HashGame(const DiscIO::Volume* volume, const ResponseCa return; } // Need to SetDisabled outside a lock because it uses m_lock internally. - bool disable = false; + bool disable = true; { std::lock_guard lg{m_lock}; - if (m_loading_volume.get() != nullptr) - { - disable = true; - } - else + if (!m_loading_volume) { m_loading_volume = DiscIO::CreateVolume(volume->GetBlobReader().CopyReader()); + disable = false; } } if (disable)