From 2b0a9477d04579877d0225b94a3bcd618dea5918 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 8 Jun 2023 12:01:56 -0400 Subject: [PATCH] MemoryViewWidget: Use QStringView with ConvertTextToBytes Allows for avoiding string copies. While we're at it, we can also mark ConvertTextToBytes as const. --- Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp | 2 +- Source/Core/DolphinQt/Debugger/MemoryViewWidget.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp b/Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp index 519dea6ebe..752c4680a0 100644 --- a/Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp @@ -609,7 +609,7 @@ AddressSpace::Type MemoryViewWidget::GetAddressSpace() const return m_address_space; } -std::vector MemoryViewWidget::ConvertTextToBytes(Type type, QString input_text) +std::vector MemoryViewWidget::ConvertTextToBytes(Type type, QStringView input_text) const { if (type == Type::Null) return {}; diff --git a/Source/Core/DolphinQt/Debugger/MemoryViewWidget.h b/Source/Core/DolphinQt/Debugger/MemoryViewWidget.h index 1b8bed117a..c958ede341 100644 --- a/Source/Core/DolphinQt/Debugger/MemoryViewWidget.h +++ b/Source/Core/DolphinQt/Debugger/MemoryViewWidget.h @@ -60,7 +60,7 @@ public: void UpdateFont(); void ToggleBreakpoint(u32 addr, bool row); - std::vector ConvertTextToBytes(Type type, QString input_text); + std::vector ConvertTextToBytes(Type type, QStringView input_text) const; void SetAddressSpace(AddressSpace::Type address_space); AddressSpace::Type GetAddressSpace() const; void SetDisplay(Type type, int bytes_per_row, int alignment, bool dual_view);