From 248a04f68f8ec66141fca8cdc0d7a786dcc4ef0a Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 6 Mar 2017 14:08:01 -0500 Subject: [PATCH] Memmap: Remove unnecessary const on function declaration parameters const, when used on value type parameters in the declaration, is superfluous. This doesn't really convey any information to take note of when using the function. This only matters in the definition when you want to prevent accidental modification. e.g. // Header void CalculateSomething(int lhs, int rhs); // Definition void CalculateSomething(const int lhs, const int rhs) { // lhs and rhs can't accidentally be modified } --- Source/Core/Core/HW/Memmap.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/Source/Core/Core/HW/Memmap.h b/Source/Core/Core/HW/Memmap.h index 10baa444ab..186dfcc610 100644 --- a/Source/Core/Core/HW/Memmap.h +++ b/Source/Core/Core/HW/Memmap.h @@ -71,20 +71,20 @@ void Clear(); // Routines to access physically addressed memory, designed for use by // emulated hardware outside the CPU. Use "Device_" prefix. std::string GetString(u32 em_address, size_t size = 0); -u8* GetPointer(const u32 address); +u8* GetPointer(u32 address); void CopyFromEmu(void* data, u32 address, size_t size); void CopyToEmu(u32 address, const void* data, size_t size); void Memset(u32 address, u8 value, size_t size); -u8 Read_U8(const u32 address); -u16 Read_U16(const u32 address); -u32 Read_U32(const u32 address); -u64 Read_U64(const u32 address); -void Write_U8(const u8 var, const u32 address); -void Write_U16(const u16 var, const u32 address); -void Write_U32(const u32 var, const u32 address); -void Write_U64(const u64 var, const u32 address); -void Write_U32_Swap(const u32 var, const u32 address); -void Write_U64_Swap(const u64 var, const u32 address); +u8 Read_U8(u32 address); +u16 Read_U16(u32 address); +u32 Read_U32(u32 address); +u64 Read_U64(u32 address); +void Write_U8(u8 var, u32 address); +void Write_U16(u16 var, u32 address); +void Write_U32(u32 var, u32 address); +void Write_U64(u64 var, u32 address); +void Write_U32_Swap(u32 var, u32 address); +void Write_U64_Swap(u64 var, u32 address); // Templated functions for byteswapped copies. template