mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-22 15:40:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

DolphinQt: RenderWidget fix heap-use-after-free

Browse Source 
The QByteArray returned by QString::toUtf8() was being freed so the char
pointer was pointing to freed memory.

Found via ASan, didn't notice any issues during normal runtime.

This was triggered after hitting a key combo with alt (ex. toggle
fullscreen) probably happens with others
This commit is contained in:
Michael Cook (mackal) 2023-04-03 10:43:49 -04:00
parent 655fca3efe
commit 241a739dc2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/DolphinQt/RenderWidget.cpp
View File

@ -488,10 +488,11 @@ void RenderWidget::PassEventToPresenter(const QEvent* event)
const u32 key = static_cast<u32>(key_event->key() & 0x1FF); const u32 key = static_cast<u32>(key_event->key() & 0x1FF);
const char* chars = nullptr; const char* chars = nullptr;
QByteArray utf8;
if (is_down) if (is_down)
{ {
auto utf8 = key_event->text().toUtf8(); utf8 = key_event->text().toUtf8();
if (utf8.size()) if (utf8.size())
chars = utf8.constData(); chars = utf8.constData();