From 1a71076e50dbf4fd33fc5834cfc61367d5a19ea6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Wed, 28 Feb 2018 16:52:26 +0100 Subject: [PATCH] IPC: Remove incorrect guess about acks A very basic hardware test shows that the ARMMSG doesn't change until IOS replies. (People could have disassembled IOS to verify this too...) Console: sending request at 00034640 - ARMMSG 133e0fa0 00000000000000000000000000000010(ack) - ARMMSG 133e0fa0 00000000000000000000000000000100(reply) - ARMMSG 00034640 Dolphin, prior to this fix: sending request (00034640) - ARMMSG 133e0fa0 00000000000000000000000000000011(ack) - ARMMSG 00034640 00000000000000000000000000000100(reply) - ARMMSG 00034640 Dolphin, after this fix: sending request at 00034640 - ARMMSG 133e0fa0 00000000000000000000000000000011(ack) - ARMMSG 133e0fa0 00000000000000000000000000000100(reply) - ARMMSG 00034640 (Yes, note that the X1 bit is still set. This is a bug that I will fix in the next commit.) --- Source/Core/Core/HW/WII_IPC.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Source/Core/Core/HW/WII_IPC.cpp b/Source/Core/Core/HW/WII_IPC.cpp index 3ba154b46d..5a60b0f04f 100644 --- a/Source/Core/Core/HW/WII_IPC.cpp +++ b/Source/Core/Core/HW/WII_IPC.cpp @@ -213,7 +213,6 @@ static void UpdateInterrupts(u64 userdata, s64 cyclesLate) void GenerateAck(u32 _Address) { - arm_msg = _Address; // dunno if it's really set here, but HLE needs to stay in context ctrl.Y2 = 1; DEBUG_LOG(WII_IPC, "GenerateAck: %08x | %08x [R:%i A:%i E:%i]", ppc_msg, _Address, ctrl.Y1, ctrl.Y2, ctrl.X1);