mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-04-25 12:02:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

InputCommon/FunctionExpression: Make MakeFunctionExpression() take a std::string_view

Browse Source 
There's nothing within this function that requires a copy of the string
to be made, so we can make use of a non-owning view
This commit is contained in:
Lioncash 2019-11-22 14:51:57 -05:00
parent ddf8abf507
commit 10fea99d80
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/InputCommon/ControlReference/FunctionExpression.cpp
View File

@ -447,7 +447,7 @@ private:
mutable Clock::time_point m_release_time = Clock::now(); mutable Clock::time_point m_release_time = Clock::now();
}; };
std::unique_ptr<FunctionExpression> MakeFunctionExpression(std::string name) std::unique_ptr<FunctionExpression> MakeFunctionExpression(std::string_view name)
{ {
if ("not" == name) if ("not" == name)
return std::make_unique<NotExpression>(); return std::make_unique<NotExpression>();

3
Source/Core/InputCommon/ControlReference/FunctionExpression.h
View File

@ -6,6 +6,7 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include <string_view>
#include <variant> #include <variant>
#include <vector> #include <vector>
@ -47,6 +48,6 @@ private:
std::vector<std::unique_ptr<Expression>> m_args; std::vector<std::unique_ptr<Expression>> m_args;
}; };
std::unique_ptr<FunctionExpression> MakeFunctionExpression(std::string name); std::unique_ptr<FunctionExpression> MakeFunctionExpression(std::string_view name);
} // namespace ciface::ExpressionParser } // namespace ciface::ExpressionParser