mirror/btstack
1
0
Fork 0
mirror of https://github.com/bluekitchen/btstack.git synced 2025-04-17 02:42:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

avrcp_target: fix compile warning using invalid pointers in memcpy with len == 0

Browse Source
This commit is contained in:
Matthias Ringwald 2020-12-08 11:18:27 +01:00
parent 5c1ef14e99
commit df842b645f
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/classic/avrcp_target.c
View File

@ -1012,7 +1012,9 @@ static int avrcp_target_send_notification(uint16_t cid, avrcp_connection_t * con
log_error("avrcp tartget: could not find a connection.");
return ERROR_CODE_UNKNOWN_CONNECTION_IDENTIFIER;
}
btstack_assert((value_len == 0) || (value != NULL));
connection->command_opcode = AVRCP_CMD_OPCODE_VENDOR_DEPENDENT;
connection->command_type = AVRCP_CTYPE_RESPONSE_CHANGED_STABLE;
connection->subunit_type = AVRCP_SUBUNIT_TYPE_PANEL;
@ -1024,6 +1026,8 @@ static int avrcp_target_send_notification(uint16_t cid, avrcp_connection_t * con
uint8_t * packet = l2cap_get_outgoing_buffer();
uint16_t size = l2cap_get_remote_mtu_for_local_cid(connection->l2cap_signaling_cid);
btstack_assert((14 + value_len) <= size);
connection->packet_type = AVRCP_SINGLE_PACKET;
packet[pos++] = (connection->transaction_id << 4) | (connection->packet_type << 2) | (AVRCP_RESPONSE_FRAME << 1) | 0;
// Profile IDentifier (PID)
@ -1043,14 +1047,14 @@ static int avrcp_target_send_notification(uint16_t cid, avrcp_connection_t * con
packet[pos++] = AVRCP_PDU_ID_REGISTER_NOTIFICATION;
packet[pos++] = 0;
uint16_t remainig_outgoing_buffer_size = size - pos - 2;
uint16_t caped_value_len = btstack_min(value_len + 1, remainig_outgoing_buffer_size);
big_endian_store_16(packet, pos, caped_value_len);
big_endian_store_16(packet, pos, value_len);
pos += 2;
packet[pos++] = notification_id;
(void)memcpy(packet + pos, value, caped_value_len - 1);
pos += caped_value_len - 1;
if (value_len > 0){
(void)memcpy(packet + pos, value, value_len);
pos += value_len;
}
connection->wait_to_send = false;
return l2cap_send_prepared(cid, pos);
}