diff --git a/CHANGELOG.md b/CHANGELOG.md index 209df673a..db94c422e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,7 +45,7 @@ HCI Dump: replace monolithic `hci_dump.c` (with many #ifdefs) into dispatcher wi - `embedded/hci_dump_embedded_stdout` - log to console using printf - `embedded/hci_dump_segger_stdout` - log to RTT console using `SEGGER_printf` - `embedded/hci_dump_segger_binary` - writes binary log over RTT to host - +FreeRTOS/Run Loop: remove `btstack_run_loop_freertos_execute_code_on_main_thread_from_isr`. A polled data source can be used instead. ## Release v1.3.2 diff --git a/platform/freertos/btstack_run_loop_freertos.c b/platform/freertos/btstack_run_loop_freertos.c index 9cca925c3..bf2d982ff 100644 --- a/platform/freertos/btstack_run_loop_freertos.c +++ b/platform/freertos/btstack_run_loop_freertos.c @@ -141,23 +141,6 @@ void btstack_run_loop_freertos_execute_code_on_main_thread(void (*fn)(void *arg) btstack_run_loop_freertos_trigger(); } -#if defined(HAVE_FREERTOS_TASK_NOTIFICATIONS) || (INCLUDE_xEventGroupSetBitFromISR == 1) -void btstack_run_loop_freertos_trigger_from_isr(void){ - BaseType_t xHigherPriorityTaskWoken; -#ifdef HAVE_FREERTOS_TASK_NOTIFICATIONS - xTaskNotifyFromISR(btstack_run_loop_task, EVENT_GROUP_FLAG_RUN_LOOP, eSetBits, &xHigherPriorityTaskWoken); - if (xHigherPriorityTaskWoken) { -#ifdef ESP_PLATFORM - portYIELD_FROM_ISR(); -#else - portYIELD_FROM_ISR( xHigherPriorityTaskWoken ); -#endif - } -#else - xEventGroupSetBitsFromISR(btstack_run_loop_event_group, EVENT_GROUP_FLAG_RUN_LOOP, &xHigherPriorityTaskWoken); -#endif -} - void btstack_run_loop_freertos_execute_code_on_main_thread_from_isr(void (*fn)(void *arg), void * arg){ function_call_t message; message.fn = fn; diff --git a/platform/freertos/btstack_run_loop_freertos.h b/platform/freertos/btstack_run_loop_freertos.h index 49d6fa12c..8587f6fe2 100644 --- a/platform/freertos/btstack_run_loop_freertos.h +++ b/platform/freertos/btstack_run_loop_freertos.h @@ -61,11 +61,6 @@ const btstack_run_loop_t * btstack_run_loop_freertos_get_instance(void); */ void btstack_run_loop_freertos_execute_code_on_main_thread(void (*fn)(void *arg), void * arg); -/* - * @brief Execute code on BTstack run loop. Can be used to control BTstack from an ISR - */ -void btstack_run_loop_freertos_execute_code_on_main_thread_from_isr(void (*fn)(void *arg), void * arg); - /** * @brief Triggers processing of data sources from thread context. * Has to be called after enabling a poll data source to wake-pup run loop.