From adca832cb7b1376bbbce411a60a24af3fce423c2 Mon Sep 17 00:00:00 2001
From: Matthias Ringwald <matthias@ringwald.ch>
Date: Thu, 18 Feb 2016 11:00:54 +0100
Subject: [PATCH] hfp_hf: api review

---
 src/hfp_hf.c |  6 ------
 src/hfp_hf.h | 17 +++++------------
 2 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/src/hfp_hf.c b/src/hfp_hf.c
index ab8cf4903..111b65642 100644
--- a/src/hfp_hf.c
+++ b/src/hfp_hf.c
@@ -70,7 +70,6 @@ static uint8_t hfp_codecs[HFP_MAX_NUM_CODECS];
 static uint8_t hfp_indicators_nr = 0;
 static uint8_t hfp_indicators[HFP_MAX_NUM_HF_INDICATORS];
 static uint32_t hfp_indicators_value[HFP_MAX_NUM_HF_INDICATORS];
-static uint16_t hfp_indicators_status;
 
 static uint8_t hfp_hf_speaker_gain = 9;
 static uint8_t hfp_hf_microphone_gain = 9;
@@ -1071,11 +1070,6 @@ void hfp_hf_set_hf_indicators(int indicators_nr, uint16_t * indicators){
     }
 }
 
-void hfp_hf_set_hf_indicators_status(uint32_t indicators_status){
-    hfp_indicators_status = indicators_status;
-}
-
-
 void hfp_hf_establish_service_level_connection(bd_addr_t bd_addr){
     hfp_establish_service_level_connection(bd_addr, SDP_HandsfreeAudioGateway);
 }
diff --git a/src/hfp_hf.h b/src/hfp_hf.h
index 21b4e3948..8243b0560 100644
--- a/src/hfp_hf.h
+++ b/src/hfp_hf.h
@@ -65,7 +65,7 @@ extern "C" {
 void hfp_hf_create_sdp_record(uint8_t * service, int rfcomm_channel_nr, const char * name, uint32_t supported_features);
 
 /**
- * @brief Set up HFP Hands-Free (HF) device. 
+ * @brief Set up HFP Hands-Free (HF) device without additional supported features 
  * 
  * @param rfcomm_channel_nr
  */
@@ -77,30 +77,23 @@ void hfp_hf_init(uint16_t rfcomm_channel_nr);
  * @param codecs_nr
  * @param codecs
  */
-void hfp_hf_set_codecs(int codecs_nr, uint8_t * codecs);
+void hfp_hf_init_codecs(int codecs_nr, uint8_t * codecs);
 
 /**
- * @brief Set supported feature bitmap. 
+ * @brief Set supported features.
  * 
  * @param supported_features 32-bit bitmap, see HFP_HFSF_* values in hfp.h
  */
-void hfp_hf_set_supported_features(uint32_t supported_features);
+void hfp_hf_init_supported_features(uint32_t supported_features);
 
 /**
  * @brief Set HF indicators. 
  * 
  * @param indicators_nr
  * @param indicators
- * @param values
  */
-void hfp_hf_set_hf_indicators(int indicators_nr, uint16_t * indicators);
+void hfp_hf_init_hf_indicators(int indicators_nr, uint16_t * indicators);
 
-/**
- * @brief Set HF indicators status bitmap. 
- * 
- * @param indicators_status 32-bit bitmap, 0 - indicator is disabled, 1 - indicator is enabled
- */
-void hfp_hf_set_hf_indicators_status(uint32_t indicators_status);
 
 /**
  * @brief Register callback for the HFP Hands-Free (HF) client.