From ada240cd034441dc38d0d7b47d5710a4f8a9ee47 Mon Sep 17 00:00:00 2001
From: Matthias Ringwald <matthias@ringwald.ch>
Date: Mon, 13 Nov 2023 15:30:22 +0100
Subject: [PATCH] hfp: support SDP record without service name

---
 src/classic/hfp.c    | 6 ++++--
 src/classic/hfp_ag.h | 2 +-
 src/classic/hfp_hf.h | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/classic/hfp.c b/src/classic/hfp.c
index a15e7aa95..3fde13836 100644
--- a/src/classic/hfp.c
+++ b/src/classic/hfp.c
@@ -751,8 +751,10 @@ void hfp_create_sdp_record(uint8_t * service, uint32_t service_record_handle, ui
     de_pop_sequence(service, attribute);
 
     // 0x0100 "Service Name"
-    de_add_number(service,  DE_UINT, DE_SIZE_16, 0x0100);
-    de_add_data(service,  DE_STRING, (uint16_t) strlen(name), (uint8_t *) name);
+    if (strlen(name) > 0){
+        de_add_number(service,  DE_UINT, DE_SIZE_16, 0x0100);
+        de_add_data(service,  DE_STRING, (uint16_t) strlen(name), (uint8_t *) name);
+    }
 }
 
 static void hfp_handle_slc_setup_error(hfp_connection_t * hfp_connection, uint8_t status){
diff --git a/src/classic/hfp_ag.h b/src/classic/hfp_ag.h
index dc2e2cc15..6ed4e0fb5 100644
--- a/src/classic/hfp_ag.h
+++ b/src/classic/hfp_ag.h
@@ -62,7 +62,7 @@ typedef struct {
  * @brief Create HFP Audio Gateway (AG) SDP service record. 
  * @param service
  * @param rfcomm_channel_nr
- * @param name
+ * @param name or NULL for default value. Provide "" (empty string) to skip attribute
  * @param ability_to_reject_call
  * @param supported_features 32-bit bitmap, see HFP_AGSF_* values in hfp.h
  * @param codecs_nr
diff --git a/src/classic/hfp_hf.h b/src/classic/hfp_hf.h
index d47ffa700..cf0650e4b 100644
--- a/src/classic/hfp_hf.h
+++ b/src/classic/hfp_hf.h
@@ -57,8 +57,8 @@ extern "C" {
  * @brief Create HFP Hands-Free (HF) SDP service record.
  * @param service
  * @param rfcomm_channel_nr
- * @param name
- * @param suported_features 32-bit bitmap, see HFP_HFSF_* values in hfp.h
+ * @param name or NULL for default value. Provide "" (empty string) to skip attribute
+ * @param supported_features 32-bit bitmap, see HFP_HFSF_* values in hfp.h
  * @param codecs_nr  number of codecs in codecs argument
  * @param codecs
  */