From 880e8fc690633d5c718ed90097c02c554bab89e9 Mon Sep 17 00:00:00 2001 From: Matthias Ringwald Date: Wed, 13 Mar 2024 14:24:48 +0100 Subject: [PATCH] hfp_ag: send OK after SLC for HF that does not support 3-way-calling or HF Indicators --- CHANGELOG.md | 1 + src/classic/hfp_ag.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 236a6607f..1340d967f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - ATT Server: support delayed read responses for registered services - ATT Server: allow to start crypto operation from delayed att read/write request - HFP HF: send HF Indicator update only if enabled by AG +- HFP AG: send OK after SLC for HF that does not support 3-way-calling or HF Indicators - HSP HS: use EV3 and 2EV3 packets for 7.5 ms voice interval ### Changed diff --git a/src/classic/hfp_ag.c b/src/classic/hfp_ag.c index fd545dc52..d51260701 100644 --- a/src/classic/hfp_ag.c +++ b/src/classic/hfp_ag.c @@ -739,14 +739,16 @@ static int hfp_ag_run_for_context_service_level_connection(hfp_connection_t * hf if (hfp_connection->state != HFP_W4_ENABLE_INDICATORS_STATUS_UPDATE) break; if (has_call_waiting_and_3way_calling_feature(hfp_connection)){ hfp_connection->state = HFP_W4_RETRIEVE_CAN_HOLD_CALL; + hfp_ag_send_ok(hfp_connection->rfcomm_cid); } else if (has_hf_indicators_feature(hfp_connection)){ hfp_connection->state = HFP_W4_LIST_GENERIC_STATUS_INDICATORS; + hfp_ag_send_ok(hfp_connection->rfcomm_cid); } else { + hfp_ag_send_ok(hfp_connection->rfcomm_cid); hfp_ag_slc_established(hfp_connection); } - hfp_ag_send_ok(hfp_connection->rfcomm_cid); return 1; - + case HFP_CMD_SUPPORT_CALL_HOLD_AND_MULTIPARTY_SERVICES: if (hfp_connection->state != HFP_W4_RETRIEVE_CAN_HOLD_CALL) break; if (has_hf_indicators_feature(hfp_connection)){