From 7ca89cabe01ec06969a60ca277f5f47c7557fd57 Mon Sep 17 00:00:00 2001 From: Matthias Ringwald Date: Fri, 26 Mar 2021 10:04:07 +0100 Subject: [PATCH] hfp: declare arrays param in init functions as const --- src/classic/hfp_ag.c | 6 +++--- src/classic/hfp_ag.h | 6 +++--- src/classic/hfp_hf.c | 4 ++-- src/classic/hfp_hf.h | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/classic/hfp_ag.c b/src/classic/hfp_ag.c index 7475db383..26df9a30d 100644 --- a/src/classic/hfp_ag.c +++ b/src/classic/hfp_ag.c @@ -2078,7 +2078,7 @@ static void hfp_ag_hci_event_packet_handler(uint8_t packet_type, uint16_t channe hfp_ag_run(); } -void hfp_ag_init_codecs(int codecs_nr, uint8_t * codecs){ +void hfp_ag_init_codecs(int codecs_nr, const uint8_t * codecs){ if (codecs_nr > HFP_MAX_NUM_CODECS){ log_error("hfp_init: codecs_nr (%d) > HFP_MAX_NUM_CODECS (%d)", codecs_nr, HFP_MAX_NUM_CODECS); return; @@ -2094,13 +2094,13 @@ void hfp_ag_init_supported_features(uint32_t supported_features){ hfp_supported_features = supported_features; } -void hfp_ag_init_ag_indicators(int ag_indicators_nr, hfp_ag_indicator_t * ag_indicators){ +void hfp_ag_init_ag_indicators(int ag_indicators_nr, const hfp_ag_indicator_t * ag_indicators){ hfp_ag_indicators_nr = ag_indicators_nr; (void)memcpy(hfp_ag_indicators, ag_indicators, ag_indicators_nr * sizeof(hfp_ag_indicator_t)); } -void hfp_ag_init_hf_indicators(int hf_indicators_nr, hfp_generic_status_indicator_t * hf_indicators){ +void hfp_ag_init_hf_indicators(int hf_indicators_nr, const hfp_generic_status_indicator_t * hf_indicators){ if (hf_indicators_nr > HFP_MAX_NUM_INDICATORS) return; hfp_generic_status_indicators_nr = hf_indicators_nr; (void)memcpy(hfp_generic_status_indicators, hf_indicators, diff --git a/src/classic/hfp_ag.h b/src/classic/hfp_ag.h index f5816d8f3..ac5464c01 100644 --- a/src/classic/hfp_ag.h +++ b/src/classic/hfp_ag.h @@ -82,7 +82,7 @@ void hfp_ag_init(uint16_t rfcomm_channel_nr); * @param codecs_nr * @param codecs */ -void hfp_ag_init_codecs(int codecs_nr, uint8_t * codecs); +void hfp_ag_init_codecs(int codecs_nr, const uint8_t * codecs); /** * @brief Set supported features. @@ -95,14 +95,14 @@ void hfp_ag_init_supported_features(uint32_t supported_features); * @param indicators_nr * @param indicators */ -void hfp_ag_init_ag_indicators(int ag_indicators_nr, hfp_ag_indicator_t * ag_indicators); +void hfp_ag_init_ag_indicators(int ag_indicators_nr, const hfp_ag_indicator_t * ag_indicators); /** * @brief Set HF indicators. * @param indicators_nr * @param indicators */ -void hfp_ag_init_hf_indicators(int hf_indicators_nr, hfp_generic_status_indicator_t * hf_indicators); +void hfp_ag_init_hf_indicators(int hf_indicators_nr, const hfp_generic_status_indicator_t * hf_indicators); /** * @brief Set Call Hold services. diff --git a/src/classic/hfp_hf.c b/src/classic/hfp_hf.c index 87f6221bd..9dcdd86c0 100644 --- a/src/classic/hfp_hf.c +++ b/src/classic/hfp_hf.c @@ -1232,7 +1232,7 @@ void hfp_hf_deinit(void){ (void) memset(phone_number, 0, sizeof(phone_number)); } -void hfp_hf_init_codecs(int codecs_nr, uint8_t * codecs){ +void hfp_hf_init_codecs(int codecs_nr, const uint8_t * codecs){ if (codecs_nr > HFP_MAX_NUM_CODECS){ log_error("hfp_hf_init_codecs: codecs_nr (%d) > HFP_MAX_NUM_CODECS (%d)", codecs_nr, HFP_MAX_NUM_CODECS); return; @@ -1249,7 +1249,7 @@ void hfp_hf_init_supported_features(uint32_t supported_features){ hfp_supported_features = supported_features; } -void hfp_hf_init_hf_indicators(int indicators_nr, uint16_t * indicators){ +void hfp_hf_init_hf_indicators(int indicators_nr, const uint16_t * indicators){ hfp_indicators_nr = indicators_nr; int i; for (i = 0; i < hfp_indicators_nr ; i++){ diff --git a/src/classic/hfp_hf.h b/src/classic/hfp_hf.h index 62c8e989f..f2c520a2b 100644 --- a/src/classic/hfp_hf.h +++ b/src/classic/hfp_hf.h @@ -76,7 +76,7 @@ void hfp_hf_init(uint16_t rfcomm_channel_nr); * @param codecs_nr * @param codecs */ -void hfp_hf_init_codecs(int codecs_nr, uint8_t * codecs); +void hfp_hf_init_codecs(int codecs_nr, const uint8_t * codecs); /** * @brief Set supported features. @@ -89,7 +89,7 @@ void hfp_hf_init_supported_features(uint32_t supported_features); * @param indicators_nr * @param indicators */ -void hfp_hf_init_hf_indicators(int indicators_nr, uint16_t * indicators); +void hfp_hf_init_hf_indicators(int indicators_nr, const uint16_t * indicators); /**