mirror/btstack
1
0
Fork 0
mirror of https://github.com/bluekitchen/btstack.git synced 2025-03-29 13:20:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

avrcp_controller: deregister only if events are already queried, and event is supported

Browse Source
This commit is contained in:
Milanka Ringwald 2021-10-26 16:40:15 +02:00
parent 66ec160393
commit 79464f8d52
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/classic/avrcp_controller.c
View File

@ -763,7 +763,7 @@ static void avrcp_controller_handle_notification(avrcp_connection_t *connection,
// we are re-enabling it automatically, if it is not
// explicitly disabled
connection->notifications_enabled &= reset_event_mask;
if (! (connection->notifications_to_deregister & event_mask)){
if ((connection->notifications_to_deregister & event_mask) == 0){
avrcp_controller_register_notification(connection, event_id);
} else {
connection->notifications_to_deregister &= reset_event_mask;
@ -1374,6 +1374,14 @@ uint8_t avrcp_controller_disable_notification(uint16_t avrcp_cid, avrcp_notifica
log_error("avrcp_get_play_status: could not find a connection.");
return ERROR_CODE_UNKNOWN_CONNECTION_IDENTIFIER;
}
if (!connection->remote_supported_notifications_queried){
return ERROR_CODE_COMMAND_DISALLOWED;
}
if ((connection->remote_supported_notifications & (1 << event_id)) == 0){
return ERROR_CODE_UNSUPPORTED_FEATURE_OR_PARAMETER_VALUE;
}
connection->notifications_to_deregister |= (1 << event_id);
return ERROR_CODE_SUCCESS;
}