fix fn() prototypes

ble/sm_minimal.c

@@ -49,7 +49,7 @@
 // SM internal types and globals
 //
 
-static void sm_run();
+static void sm_run(void);
 
 // used to notify applicationss that user interaction is neccessary, see sm_notify_t below
 static btstack_packet_handler_t sm_client_packet_handler = NULL;

example/embedded/hfp_ag_demo.c

@@ -108,7 +108,7 @@ static hfp_generic_status_indicator_t hf_indicators[] = {
 
 char cmd;
 // prototypes
-static void show_usage();
+static void show_usage(void);
 
 // GAP INQUIRY
 

example/embedded/hfp_hf_demo.c

@@ -89,7 +89,7 @@ static uint16_t indicators[1] = {0x01};
 char cmd;
 
 // prototypes
-static void show_usage();
+static void show_usage(void);
 
 // Testig User Interface 
 static void show_usage(void){

platforms/posix/src/hci_transport_h2_libusb.c

@@ -1025,7 +1025,7 @@ static void dummy_handler(uint8_t packet_type, uint8_t *packet, uint16_t size){
 }
 
 // get usb singleton
-hci_transport_t * hci_transport_usb_instance() {
+hci_transport_t * hci_transport_usb_instance(void) {
     if (!hci_transport_usb) {
         hci_transport_usb = (hci_transport_t*) malloc( sizeof(hci_transport_t));
         hci_transport_usb->open                          = usb_open;

platforms/posix/src/hci_transport_h4.c

@@ -332,7 +332,7 @@ static void dummy_handler(uint8_t packet_type, uint8_t *packet, uint16_t size){
 }
 
 // get h4 singleton
-hci_transport_t * hci_transport_h4_instance() {
+hci_transport_t * hci_transport_h4_instance(void) {
     if (hci_transport_h4 == NULL) {
         hci_transport_h4 = (hci_transport_h4_t*)malloc( sizeof(hci_transport_h4_t));
         hci_transport_h4->ds                                      = NULL;

platforms/posix/src/hci_transport_h5.c

@@ -297,7 +297,7 @@ static void dummy_handler(uint8_t *packet, int size){
 }
 
 // get h5 singleton
-hci_transport_t * hci_transport_h5_instance() {
+hci_transport_t * hci_transport_h5_instance(void) {
     if (hci_transport_h5 == NULL) {
         hci_transport_h5 = malloc( sizeof(hci_transport_h5_t));
         hci_transport_h5->ds                                      = NULL;

src/hci.c

@@ -3461,7 +3461,7 @@ void hci_set_sco_voice_setting(uint16_t voice_setting){
  * @brief Get SCO Voice Setting
  * @return current voice setting
  */
-uint16_t hci_get_sco_voice_setting(){
+uint16_t hci_get_sco_voice_setting(void){
     return hci_stack->sco_voice_setting;
 }
 

src/hfp.c

@@ -218,7 +218,7 @@ static void hfp_emit_audio_connection_established_event(hfp_callback_t callback,
     (*callback)(event, sizeof(event));
 }
 
-linked_list_t * hfp_get_connections(){
+linked_list_t * hfp_get_connections(void){
     return (linked_list_t *) &hfp_connections;
 } 
 

src/hfp_ag.c

@@ -139,7 +139,7 @@ void hfp_ag_register_packet_handler(hfp_callback_t callback){
     hfp_callback = callback;
 }
 
-static int use_in_band_tone(){
+static int use_in_band_tone(void){
     return get_bit(hfp_supported_features, HFP_AGSF_IN_BAND_RING_TONE);
 }
 
@@ -1005,7 +1005,7 @@ static void hfp_ag_trigger_terminate_call(void){
     hfp_emit_simple_event(hfp_callback, HFP_SUBEVENT_CALL_TERMINATED);
 }
 
-static void hfp_ag_set_callsetup_indicator(){
+static void hfp_ag_set_callsetup_indicator(void){
     hfp_ag_indicator_t * indicator = get_ag_indicator_for_name("callsetup");
     if (!indicator){
         log_error("hfp_ag_set_callsetup_indicator: callsetup indicator is missing");
@@ -1013,7 +1013,7 @@ static void hfp_ag_set_callsetup_indicator(){
     indicator->status = hfp_gsm_callsetup_status();
 }
 
-static void hfp_ag_set_callheld_indicator(){
+static void hfp_ag_set_callheld_indicator(void){
     hfp_ag_indicator_t * indicator = get_ag_indicator_for_name("callheld");
     if (!indicator){
         log_error("hfp_ag_set_callheld_state: callheld indicator is missing");
@@ -1021,7 +1021,7 @@ static void hfp_ag_set_callheld_indicator(){
     indicator->status = hfp_gsm_callheld_status();
 }
 
-static void hfp_ag_set_call_indicator(){
+static void hfp_ag_set_call_indicator(void){
     hfp_ag_indicator_t * indicator = get_ag_indicator_for_name("call");
     if (!indicator){
         log_error("hfp_ag_set_call_state: call indicator is missing");

test/gatt_client/gatt_client_test.c

@@ -72,8 +72,8 @@ static le_service_t included_services[50];
 static le_characteristic_t characteristics[50];
 static le_characteristic_descriptor_t descriptors[50];
 
-void mock_simulate_discover_primary_services_response();
-void mock_simulate_att_exchange_mtu_response();
+void mock_simulate_discover_primary_services_response(void);
+void mock_simulate_att_exchange_mtu_response(void);
 
 void CHECK_EQUAL_ARRAY(const uint8_t * expected, uint8_t * actual, int size){
 	for (int i=0; i<size; i++){

test/gatt_client/le_central.c

@@ -25,10 +25,10 @@ static uint8_t advertisement_received;
 static uint8_t connected;
 static uint8_t advertisement_packet[150];
 
-void mock_simulate_hci_state_working();
+void mock_simulate_hci_state_working(void);
 void mock_simulate_command_complete(const hci_cmd_t *cmd);
-void mock_simulate_scan_response();
-void mock_simulate_connected();
+void mock_simulate_scan_response(void);
+void mock_simulate_connected(void);
 
 
 void CHECK_EQUAL_ARRAY(const uint8_t * expected, uint8_t * actual, int size){

test/gatt_client/mock.c

@@ -83,7 +83,7 @@ uint16_t l2cap_max_le_mtu(void){
     return max_mtu;
 }
 
-void l2cap_init(){}
+void l2cap_init(void){}
 
 void l2cap_register_fixed_channel(btstack_packet_handler_t packet_handler, uint16_t channel_id) {
     att_packet_handler = packet_handler;

test/hfp/hfp_ag_client_test.c

@@ -111,11 +111,11 @@ static hfp_generic_status_indicator_t hf_indicators[] = {
 static uint16_t handle = -1;
 static int memory_1_enabled = 1;
 
-int has_more_hfp_ag_commands(){
+int has_more_hfp_ag_commands(void){
     return has_more_hfp_commands(2,2);
 }
 
-char * get_next_hfp_ag_command(){
+char * get_next_hfp_ag_command(void){
    return get_next_hfp_command(2,2);
 }
 

test/hfp/hfp_hf_client_test.c

@@ -84,11 +84,11 @@ static int supported_features_with_codec_negotiation = 438;
 
 static uint16_t handle = -1;
 
-char * get_next_hfp_hf_command(){
+char * get_next_hfp_hf_command(void){
     return get_next_hfp_command(0,2);
 }
 
-int has_more_hfp_hf_commands(){
+int has_more_hfp_hf_commands(void){
     return has_more_hfp_commands(0,2);
 }
 

test/hfp/mock.c

@@ -75,11 +75,11 @@ hfp_connection_t * hfp_context;
 void (*registered_rfcomm_packet_handler)(void * connection, uint8_t packet_type, uint16_t channel, uint8_t *packet, uint16_t size);
 void (*registered_sdp_app_callback)(sdp_query_event_t * event, void * context);
 
-uint8_t * get_rfcomm_payload(){
+uint8_t * get_rfcomm_payload(void){
 	return &rfcomm_payload[0];
 }
 
-uint16_t get_rfcomm_payload_len(){
+uint16_t get_rfcomm_payload_len(void){
 	return rfcomm_payload_len;
 }
 
@@ -173,7 +173,7 @@ int rfcomm_send_prepared(uint16_t rfcomm_cid, uint16_t len){
     return rfcomm_send_internal(rfcomm_cid, rfcomm_reserved_buffer, len);
 }
 
-static void hci_event_sco_complete(){
+static void hci_event_sco_complete(void){
     uint8_t event[19];
     uint8_t pos = 0;
     event[pos++] = HCI_EVENT_SYNCHRONOUS_CONNECTION_COMPLETE;
@@ -311,7 +311,7 @@ le_command_status_t gap_disconnect(hci_con_handle_t handle){
     return BLE_PERIPHERAL_OK;
 }
 
-uint16_t hci_get_sco_voice_setting(){
+uint16_t hci_get_sco_voice_setting(void){
     return 0x40;
 }
 

test/hfp/test_sequences.c

@@ -4126,47 +4126,47 @@ hfp_test_item_t pts_hf_rhh_tests[] = {
 static int test_item_size = sizeof(hfp_test_item_t);
 
 // CC
-int hfp_cc_tests_size(){ return sizeof(cc_tests) /test_item_size;}
-hfp_test_item_t * hfp_cc_tests(){ return cc_tests;}
-hfp_test_item_t * default_hfp_cc_test(){ return &cc_tests[0];}
+int hfp_cc_tests_size(void){ return sizeof(cc_tests) /test_item_size;}
+hfp_test_item_t * hfp_cc_tests(void){ return cc_tests;}
+hfp_test_item_t * default_hfp_cc_test(void){ return &cc_tests[0];}
 
 // PTS - SLC Group
-int hfp_pts_ag_slc_tests_size(){ return sizeof(pts_ag_slc_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_ag_slc_tests(){ return pts_ag_slc_tests;}
+int hfp_pts_ag_slc_tests_size(void){ return sizeof(pts_ag_slc_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_ag_slc_tests(void){ return pts_ag_slc_tests;}
 
-int hfp_pts_hf_slc_tests_size(){ return sizeof(pts_hf_slc_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_hf_slc_tests(){ return pts_hf_slc_tests;}
+int hfp_pts_hf_slc_tests_size(void){ return sizeof(pts_hf_slc_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_hf_slc_tests(void){ return pts_hf_slc_tests;}
 
 // PTS - ATA Group
-int hfp_pts_ag_ata_tests_size(){ return sizeof(pts_ag_ata_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_ag_ata_tests(){ return pts_ag_ata_tests;}
+int hfp_pts_ag_ata_tests_size(void){ return sizeof(pts_ag_ata_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_ag_ata_tests(void){ return pts_ag_ata_tests;}
 
-int hfp_pts_hf_ata_tests_size(){ return sizeof(pts_hf_ata_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_hf_ata_tests(){ return pts_hf_ata_tests;}
+int hfp_pts_hf_ata_tests_size(void){ return sizeof(pts_hf_ata_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_hf_ata_tests(void){ return pts_hf_ata_tests;}
 
 // PTS - TWC Group
-int hfp_pts_ag_twc_tests_size(){ return sizeof(pts_ag_twc_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_ag_twc_tests(){ return pts_ag_twc_tests;}
-int hfp_pts_hf_twc_tests_size(){ return sizeof(pts_hf_twc_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_hf_twc_tests(){ return pts_hf_twc_tests;}
+int hfp_pts_ag_twc_tests_size(void){ return sizeof(pts_ag_twc_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_ag_twc_tests(void){ return pts_ag_twc_tests;}
+int hfp_pts_hf_twc_tests_size(void){ return sizeof(pts_hf_twc_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_hf_twc_tests(void){ return pts_hf_twc_tests;}
 
 // PTS - ECS Group
-int hfp_pts_ag_ecs_tests_size(){ return sizeof(pts_ag_ecs_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_ag_ecs_tests(){ return pts_ag_ecs_tests;}
-int hfp_pts_hf_ecs_tests_size(){ return sizeof(pts_hf_ecs_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_hf_ecs_tests(){ return pts_hf_ecs_tests;}
+int hfp_pts_ag_ecs_tests_size(void){ return sizeof(pts_ag_ecs_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_ag_ecs_tests(void){ return pts_ag_ecs_tests;}
+int hfp_pts_hf_ecs_tests_size(void){ return sizeof(pts_hf_ecs_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_hf_ecs_tests(void){ return pts_hf_ecs_tests;}
 
 // PTS - ECC Group
-int hfp_pts_ag_ecc_tests_size(){ return sizeof(pts_ag_ecc_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_ag_ecc_tests(){ return pts_ag_ecc_tests;}
-int hfp_pts_hf_ecc_tests_size(){ return sizeof(pts_hf_ecc_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_hf_ecc_tests(){ return pts_hf_ecc_tests;}
+int hfp_pts_ag_ecc_tests_size(void){ return sizeof(pts_ag_ecc_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_ag_ecc_tests(void){ return pts_ag_ecc_tests;}
+int hfp_pts_hf_ecc_tests_size(void){ return sizeof(pts_hf_ecc_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_hf_ecc_tests(void){ return pts_hf_ecc_tests;}
 
 // PTS - RHH Group
-int hfp_pts_ag_rhh_tests_size(){ return sizeof(pts_ag_rhh_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_ag_rhh_tests(){ return pts_ag_rhh_tests;}
-int hfp_pts_hf_rhh_tests_size(){ return sizeof(pts_hf_rhh_tests)/test_item_size;}
-hfp_test_item_t * hfp_pts_hf_rhh_tests(){ return pts_hf_rhh_tests;}
+int hfp_pts_ag_rhh_tests_size(void){ return sizeof(pts_ag_rhh_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_ag_rhh_tests(void){ return pts_ag_rhh_tests;}
+int hfp_pts_hf_rhh_tests_size(void){ return sizeof(pts_hf_rhh_tests)/test_item_size;}
+hfp_test_item_t * hfp_pts_hf_rhh_tests(void){ return pts_hf_rhh_tests;}
 
 
  

test/pts/ble_central_test.c

@@ -193,7 +193,7 @@ static le_characteristic_t gap_reconnection_address_characteristic;
 static le_characteristic_t gap_peripheral_privacy_flag_characteristic;
 static le_characteristic_t signed_write_characteristic;
 
-static void show_usage();
+static void show_usage(void);
 ///
 
 static void printUUID(uint8_t * uuid128, uint16_t uuid16){

test/pts/ble_peripheral_test.c

@@ -118,9 +118,9 @@ static uint16_t client_configuration_handle;
 
 static uint16_t handle = 0;
 
-static void app_run();
-static void show_usage();
-static void update_advertisements();
+static void app_run(void);
+static void show_usage(void);
+static void update_advertisements(void);
 
 
 // static bd_addr_t tester_address = {0x00, 0x1B, 0xDC, 0x06, 0x07, 0x5F};

test/pts/bnep_test.c

@@ -91,7 +91,7 @@
 #define ARP_OPERATION_REPLY   2
 
 // prototypes
-static void show_usage();
+static void show_usage(void);
 
 // Configuration for PTS
 static bd_addr_t pts_addr = {0x00,0x1b,0xDC,0x07,0x32,0xEF};

test/pts/classic_test.c

@@ -63,7 +63,7 @@
 #include "sm.h"
 #include "stdin_support.h"
 
-static void show_usage();
+static void show_usage(void);
 
 // static bd_addr_t remote = {0x04,0x0C,0xCE,0xE4,0x85,0xD3};
 // static bd_addr_t remote = {0x84, 0x38, 0x35, 0x65, 0xD1, 0x15};

test/pts/hfp_ag_test.c

@@ -102,7 +102,7 @@ static hfp_generic_status_indicator_t hf_indicators[] = {
 
 char cmd;
 // prototypes
-static void show_usage();
+static void show_usage(void);
 
 // GAP INQUIRY
 

test/pts/hfp_hf_test.c

@@ -85,7 +85,7 @@ static uint16_t indicators[1] = {0x01};
 char cmd;
 
 // prototypes
-static void show_usage();
+static void show_usage(void);
 
 // Testig User Interface 
 static void show_usage(void){

test/pts/hsp_hs_test.c

@@ -92,7 +92,7 @@ static bd_addr_t current_addr;
 static char hs_cmd_buffer[100];
 
 // prototypes
-static void show_usage();
+static void show_usage(void);
 
 // Testig User Interface 
 static void show_usage(void){

test/pts/l2cap_test.c

@@ -59,7 +59,7 @@
 #include "l2cap.h"
 #include "stdin_support.h"
  
-static void show_usage();
+static void show_usage(void);
 
 // static bd_addr_t remote = {0x04,0x0C,0xCE,0xE4,0x85,0xD3};
 static bd_addr_t remote = {0x84, 0x38, 0x35, 0x65, 0xD1, 0x15};

test/remote_device_db/remote_device_db_fs_test.c

@@ -8,7 +8,7 @@
 
 #include "btstack-config.h"
 
-const remote_device_db_t * remote_device_db_fs_instance();
+const remote_device_db_t * remote_device_db_fs_instance(void);
 
 TEST_GROUP(RemoteDeviceDB){
     bd_addr_t bd_addr;

test/sdp_client/sdp_rfcomm_query.c

@@ -86,7 +86,7 @@ extern "C" void sdp_client_query(bd_addr_t remote, uint8_t * des_serviceSearchPa
 }
 
 // for test purposes
-void sdp_query_rfcomm_init();
+void sdp_query_rfcomm_init(void);
 
 
 void handle_query_rfcomm_event(sdp_query_event_t * event, void * context){