From 3721458b9d80a410d30f1de9b97d6e79b1aa642f Mon Sep 17 00:00:00 2001
From: Matthias Ringwald <matthias@ringwald.ch>
Date: Thu, 21 Sep 2017 14:17:44 +0200
Subject: [PATCH] device_information_service: fix
 device_information_service_server_set_pnp_id

---
 src/ble/gatt-service/device_information_service_server.c | 7 ++++---
 src/ble/gatt-service/device_information_service_server.h | 3 ++-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/ble/gatt-service/device_information_service_server.c b/src/ble/gatt-service/device_information_service_server.c
index 0e9b4880b..3f4cc4b7f 100644
--- a/src/ble/gatt-service/device_information_service_server.c
+++ b/src/ble/gatt-service/device_information_service_server.c
@@ -101,6 +101,7 @@ static void set_string(device_information_field_id_t field_id, const char * text
 }
 
 static uint16_t device_information_service_read_callback(hci_con_handle_t con_handle, uint16_t attribute_handle, uint16_t offset, uint8_t * buffer, uint16_t buffer_size){
+	UNUSED(con_handle);	// ok: info same for all devices
 	int i;
 	for (i=0;i<NUM_INFORMATION_FIELDS;i++){
 		if (device_information_fields[i].value_handle != attribute_handle) continue;
@@ -223,7 +224,7 @@ void device_information_service_server_set_pnp_id(uint8_t vendor_source_id, uint
 	device_information_fields[PNP_ID].len = 7;
 
 	device_information_pnp_id[0] = vendor_source_id;
-	little_endian_store_16(device_information_pnp_id, 1, vendor_source_id);
-	little_endian_store_16(device_information_pnp_id, 3, vendor_id);
-	little_endian_store_16(device_information_pnp_id, 5, product_id);
+	little_endian_store_16(device_information_pnp_id, 1, vendor_id);
+	little_endian_store_16(device_information_pnp_id, 3, product_id);
+	little_endian_store_16(device_information_pnp_id, 5, product_version);
 }
diff --git a/src/ble/gatt-service/device_information_service_server.h b/src/ble/gatt-service/device_information_service_server.h
index 23c88c88d..a4475b981 100644
--- a/src/ble/gatt-service/device_information_service_server.h
+++ b/src/ble/gatt-service/device_information_service_server.h
@@ -113,10 +113,11 @@ void device_information_service_server_set_system_id(uint64_t manufacturer_ident
 void device_information_service_server_set_ieee_regulatory_certification(uint16_t value_a, uint16_t value_b);
 
 /**
- * @brief Set Software Revision
+ * @brief Set PnP ID
  * @param vendor_source_id
  * @param vendor_id
  * @param product_id
+ * @Param product_versoin
  */
 void device_information_service_server_set_pnp_id(uint8_t vendor_source_id, uint16_t vendor_id, uint16_t product_id, uint16_t product_version);