hid_host: fix delete descriptor similar to PR #528

This commit is contained in:
Matthias Ringwald 2023-09-10 19:53:25 +02:00
parent 9c228539c3
commit 04b99c5b35

View File

@ -121,12 +121,15 @@ static hid_host_connection_t * hid_host_get_connection_for_l2cap_cid(uint16_t l2
} }
static void hid_descriptor_storage_init(hid_host_connection_t * connection){ static void hid_descriptor_storage_init(hid_host_connection_t * connection){
// reserve remaining space for this connection
uint16_t available_space = hid_descriptor_storage_get_available_space();
connection->hid_descriptor_len = 0; connection->hid_descriptor_len = 0;
connection->hid_descriptor_max_len = hid_descriptor_storage_get_available_space(); connection->hid_descriptor_max_len = available_space;
connection->hid_descriptor_offset = hid_host_descriptor_storage_len - connection->hid_descriptor_max_len; connection->hid_descriptor_offset = hid_host_descriptor_storage_len - available_space;
} }
static bool hid_descriptor_storage_store(hid_host_connection_t * connection, uint8_t byte){ static bool hid_descriptor_storage_store(hid_host_connection_t * connection, uint8_t byte){
// store single hid descriptor byte
if (connection->hid_descriptor_len >= connection->hid_descriptor_max_len) return false; if (connection->hid_descriptor_len >= connection->hid_descriptor_max_len) return false;
hid_host_descriptor_storage[connection->hid_descriptor_offset + connection->hid_descriptor_len] = byte; hid_host_descriptor_storage[connection->hid_descriptor_offset + connection->hid_descriptor_len] = byte;
@ -135,24 +138,31 @@ static bool hid_descriptor_storage_store(hid_host_connection_t * connection, uin
} }
static void hid_descriptor_storage_delete(hid_host_connection_t * connection){ static void hid_descriptor_storage_delete(hid_host_connection_t * connection){
uint16_t next_offset = connection->hid_descriptor_offset + connection->hid_descriptor_len; uint16_t descriptor_len = connection->hid_descriptor_len;
memmove(&hid_host_descriptor_storage[connection->hid_descriptor_offset], if (descriptor_len > 0){
&hid_host_descriptor_storage[next_offset], uint16_t next_offset = connection->hid_descriptor_offset + connection->hid_descriptor_len;
hid_host_descriptor_storage_len - next_offset);
connection->hid_descriptor_len = 0; // move higher descriptors down
connection->hid_descriptor_offset = 0; memmove(&hid_host_descriptor_storage[connection->hid_descriptor_offset],
&hid_host_descriptor_storage[next_offset],
hid_host_descriptor_storage_len - next_offset);
btstack_linked_list_iterator_t it; // fix descriptor offset of higher descriptors
btstack_linked_list_iterator_init(&it, &hid_host_connections); btstack_linked_list_iterator_t it;
while (btstack_linked_list_iterator_has_next(&it)){ btstack_linked_list_iterator_init(&it, &hid_host_connections);
hid_host_connection_t * conn = (hid_host_connection_t *)btstack_linked_list_iterator_next(&it); while (btstack_linked_list_iterator_has_next(&it)){
if (conn->hid_descriptor_offset >= next_offset){ hid_host_connection_t * conn = (hid_host_connection_t *)btstack_linked_list_iterator_next(&it);
conn->hid_descriptor_offset = next_offset; if (conn == connection) continue;
next_offset += conn->hid_descriptor_len; if (conn->hid_descriptor_offset >= next_offset){
conn->hid_descriptor_offset -= descriptor_len;
}
} }
} }
// clear descriptor
connection->hid_descriptor_len = 0;
connection->hid_descriptor_offset = 0;
} }
const uint8_t * hid_descriptor_storage_get_descriptor_data(uint16_t hid_cid){ const uint8_t * hid_descriptor_storage_get_descriptor_data(uint16_t hid_cid){