btstack/tool/conversion_to_v1.0/convert.cocci

@@
expression dest, src;
@@
- bt_flip_addr(dest,src)
+ reverse_bd_addr(src, dest)

@@
expression handle;
@@
- hci_remote_eSCO_supported(handle)
+ hci_remote_esco_supported(handle)

@@
expression packet_handler;
@@
- hci_register_packet_handler(packet_handler);
+ static btstack_packet_callback_registration_t callback_registration;
+ callback_registration.callback = packet_handler;
+ hci_add_event_handler(&callback_registration);

@@
typedef uint8_t, uint16_t;
identifier fn, packet_type, packet, size;
@@
- void fn(uint8_t packet_type, uint8_t * packet, uint16_t size)
+ void fn(uint8_t packet_type, uint16_t channel, uint8_t * packet, uint16_t size)
{ ... }

@@
// typedef uint8_t, uint16_t;
identifier fn, connection, packet_type, channel, packet, size;
@@
- void fn(void * connection, uint8_t packet_type, uint16_t channel, uint8_t * packet, uint16_t size)
+ void fn(uint8_t packet_type, uint16_t channel, uint8_t * packet, uint16_t size)
{ ... }

@@
expression handle;
@@
- hci_can_send_sco_packet_now(handle)
+ hci_can_send_sco_packet_now()  

@@
expression uuid;
@@
- printUUID128(uuid)
+ printf("%s", uuid128_to_str(uuid))

@@
expression addr;
@@
- print_bd_addr(addr)
+ printf("%s", bd_addr_to_str(addr))

@@
expression str, addr;
typedef bd_addr_t;
@@
- sscan_bd_addr((uint8_t*)str, addr)
+ sscanf_bd_addr(str, addr)

@@
typedef timer;
typedef btstack_timer_source_t;
identifier fn, ts;
@@
- fn(struct timer * ts)
+ fn(btstack_timer_source_t * ts)
{ ... }

// SDP Client

// propagate sdp client callback into individual sdp client calls
// add warning that type doesn't match

// remove sdp_parser_init()
@@
@@
- sdp_parser_init();

// track calls to sdp_parser_register_callback
@sdp_parser_register_callback@
identifier sdp_client_callback;
@@
- sdp_parser_register_callback(sdp_client_callback);

// fix calls for sdp_query_util.h 
@@
identifier sdp_parser_register_callback.sdp_client_callback;
expression E1, E2;
@@
- sdp_general_query_for_uuid(E1, E2)
+ sdp_client_query_uuid16(sdp_client_callback, E1, E2)

@@
identifier sdp_parser_register_callback.sdp_client_callback;
expression E1, E2;
@@
- sdp_general_query_for_uuid128(E1, E2)
+ sdp_client_query_uuid128(sdp_client_callback, E1, E2)

// fix calls for sdp_client.h
@@
identifier sdp_parser_register_callback.sdp_client_callback;
expression E1, E2, E3;
@@
+ sdp_client_query(E1, E2, E3)
- sdp_client_query(sdp_client_callback, E1, E2, E3)

// track calls to sdp_query_rfcomm_register_callback
@sdp_query_rfcomm_register_callback @
identifier sdp_client_callback;
expression E1;
@@
- sdp_query_rfcomm_register_callback(sdp_client_callback, E1);

@@
typedef sdp_query_event_t;
identifier fn, event;
type T;
@@
- T fn(sdp_query_event_t * event)
+
+ // MIGRATION: SDP Client callback changed to btstack_packet_handler_t
+ // Please  use sdp_client_X functions from btstack_event.h to access event fields
+ T fn(uint8_t packet_type, uint16_t channel, uint8_t * packet, uint16_t size)
{ ... }

// fix calls to sdp_query_rfcomm 
@@
identifier sdp_query_rfcomm_register_callback.sdp_client_callback;
expression E1, E2;
@@
- sdp_query_rfcomm_channel_and_name_for_uuid(E1, E2)
+ sdp_query_rfcomm_channel_and_name_for_uuid(sdp_client_callback, E1, E2)

@@
identifier sdp_query_rfcomm_register_callback.sdp_client_callback;
expression E1, E2;
@@
- sdp_query_rfcomm_channel_and_name_for_search_pattern(E1, E2)
+ sdp_query_rfcomm_channel_and_name_for_search_pattern(sdp_client_callback, E1, E2)

@@
identifier fn, event, context;
type T;
@@
- T fn(sdp_query_event_t * event, void * context)
+
+ // MIGRATION: SDP Client callback changed to btstack_packet_handler_t
+ // Please  use sdp_client_X functions from btstack_event.h to access event fields
+ T fn(uint8_t packet_type, uint16_t channel, uint8_t * packet, uint16_t size)
{ ... }

// SDP Util

@@
expression E1, E2, E3;
@@
- sdp_create_spp_service(E1, E2, E3)
+ // MIGRATION: using 0x10001 as Service Record Handle. Please fix if using multiple services
+ sdp_create_spp_service(E1, 0x10001, E2, E3)

// SDP Server
@@
expression E1, E2;
@@
- sdp_register_service(E1, E2)
+ sdp_register_service(E2)

// RFCOMM

// track calls to rfcomm_register_packet_handler
@rfcomm_register_packet_handler@
identifier rfcomm_callback;
@@
- rfcomm_register_packet_handler(rfcomm_callback);

// fix calls to 
// rfcomm_register_service
@@
identifier rfcomm_register_packet_handler.rfcomm_callback;
expression E1, E2, E3;
@@
- rfcomm_register_service(E1, E2, E3)
+ rfcomm_register_service(rfcomm_callback, E2, E3)

// rfcomm_register_service_with_initial_credits,
@@
identifier rfcomm_register_packet_handler.rfcomm_callback;
expression E1, E2, E3, E4;
@@
- rfcomm_register_service_with_initial_credits(E1, E2, E3, E4)
+ rfcomm_register_service_with_initial_credits(rfcomm_callback, E2, E3, E4)

// rfcomm_create_channel
@@
identifier rfcomm_register_packet_handler.rfcomm_callback;
expression E1, E2, E3;
@@
- rfcomm_create_channel(E1, E2, E3)
+ rfcomm_create_channel(rfcomm_callback, E2, E3)

// rfcomm_create_channel_with_initial_credits
@@
identifier rfcomm_register_packet_handler.rfcomm_callback;
expression E1, E2, E3, E4;
@@
- rfcomm_create_channel_with_initial_creditis(E1, E2, E3, E4)
+ rfcomm_create_channel_with_initial_creditis(rfcomm_callback, E2, E3, E4)



// GATT Client

// HSP
@@
expression E1, E2, E3, E4;
@@
- hsp_hs_create_sdp_record(E1, E2, E3, E4)
+ // MIGRATION: using 0x10002 as Service Record Handle. Please fix if using multiple services
+ hsp_hs_create_sdp_record(E1, 0x10002, E2, E3, E4)

@@
expression E1, E2, E3, E4;
@@
- hsp_ag_create_sdp_record(E1, E2, E3)
+ // MIGRATION: using 0x10002 as Service Record Handle. Please fix if using multiple services
+ hsp_ag_create_sdp_record(E1, 0x10002, E2, E3)