From d9c3e5f3ad28a55102a6c880324ef8ac80ddf276 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Wed, 10 Dec 2014 16:50:21 +0000 Subject: [PATCH] Fix/merge advice on low percentage progress bars - actually add the ``min-width`` extra style (and use ``em`` rather than ``px``) to the 0% and 2% example - remove the unnecessarily redundant sentence in the "With labels" section - remove the unnecessary heading/section specifically for low percentage case, make it flow naturally as part of the "With labels" section --- docs/_includes/components/progress-bars.html | 14 ++++++-------- docs/_includes/nav/components.html | 1 - 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/docs/_includes/components/progress-bars.html b/docs/_includes/components/progress-bars.html index 88340105b5..68d87e090b 100644 --- a/docs/_includes/components/progress-bars.html +++ b/docs/_includes/components/progress-bars.html @@ -26,7 +26,7 @@ {% endhighlight %}

With label

-

Remove the .sr-only class from within the progress bar to show a visible percentage. For low percentages, consider adding a min-width to ensure the label's text is fully visible.

+

Remove the <span> with .sr-only class from within the progress bar to show a visible percentage.

@@ -41,29 +41,27 @@
{% endhighlight %} - -

Low percentages

-

Progress bars representing low single digit percentages, as well as 0%, include a min-width: 20px; for legibility.

+

To ensure that the label text remains legible even for low percentages, consider adding a min-width to the progress bar.

-
+
0%
-
+
2%
{% highlight html %}
-
+
0%
-
+
2%
diff --git a/docs/_includes/nav/components.html b/docs/_includes/nav/components.html index 9c5f5126fc..49c8040c53 100644 --- a/docs/_includes/nav/components.html +++ b/docs/_includes/nav/components.html @@ -105,7 +105,6 @@