From 6063b0dc659e7ba3a83cfc9502ad7872f8201a32 Mon Sep 17 00:00:00 2001
From: Johann-S <johann.servoire@gmail.com>
Date: Thu, 27 Jul 2017 12:58:22 +0200
Subject: [PATCH] Enable the `no-return-assign` rule.

---
 js/.eslintrc.json | 2 +-
 js/src/popover.js | 3 ++-
 js/src/tooltip.js | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/js/.eslintrc.json b/js/.eslintrc.json
index fdca9c1dd2..cc4e58ebd1 100644
--- a/js/.eslintrc.json
+++ b/js/.eslintrc.json
@@ -74,7 +74,7 @@
     "no-param-reassign": "off",
     "no-proto": "error",
     "no-restricted-properties": "error",
-    "no-return-assign": "off",
+    "no-return-assign": "error",
     "no-return-await": "error",
     "no-script-url": "error",
     "no-self-compare": "error",
diff --git a/js/src/popover.js b/js/src/popover.js
index 7639e3e203..f5820ecbed 100644
--- a/js/src/popover.js
+++ b/js/src/popover.js
@@ -114,7 +114,8 @@ const Popover = (($) => {
     }
 
     getTipElement() {
-      return this.tip = this.tip || $(this.config.template)[0]
+      this.tip = this.tip || $(this.config.template)[0]
+      return this.tip
     }
 
     setContent() {
diff --git a/js/src/tooltip.js b/js/src/tooltip.js
index 721f044818..7dfe9dfc03 100644
--- a/js/src/tooltip.js
+++ b/js/src/tooltip.js
@@ -415,7 +415,8 @@ const Tooltip = (($) => {
     }
 
     getTipElement() {
-      return this.tip = this.tip || $(this.config.template)[0]
+      this.tip = this.tip || $(this.config.template)[0]
+      return this.tip
     }
 
     setContent() {