mirror/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-02-24 03:40:10 +00:00
Code Issues Projects Releases Wiki Activity

Change element.parentNode.removeChild(element) to element.remove() (#34071)

Browse Source
This commit is contained in:
GeoSot 2021-05-25 18:30:38 +03:00 committed by GitHub
parent 69a9b87945
commit 544d9ac3cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/src/alert.js
View File

@ -78,9 +78,7 @@ class Alert extends BaseComponent {
} }
_destroyElement(element) { _destroyElement(element) {
if (element.parentNode) { element.remove()
element.parentNode.removeChild(element)
}
EventHandler.trigger(element, EVENT_CLOSED) EventHandler.trigger(element, EVENT_CLOSED)
} }

4
js/src/popover.js
View File

@ -98,11 +98,11 @@ class Popover extends Tooltip {
this.tip = super.getTipElement() this.tip = super.getTipElement()
if (!this.getTitle()) { if (!this.getTitle()) {
this.tip.removeChild(SelectorEngine.findOne(SELECTOR_TITLE, this.tip)) SelectorEngine.findOne(SELECTOR_TITLE, this.tip).remove()
} }
if (!this._getContent()) { if (!this._getContent()) {
this.tip.removeChild(SelectorEngine.findOne(SELECTOR_CONTENT, this.tip)) SelectorEngine.findOne(SELECTOR_CONTENT, this.tip).remove()
} }
return this.tip return this.tip

8
js/src/tooltip.js
View File

@ -208,8 +208,8 @@ class Tooltip extends BaseComponent {
EventHandler.off(this._element.closest(`.${CLASS_NAME_MODAL}`), 'hide.bs.modal', this._hideModalHandler) EventHandler.off(this._element.closest(`.${CLASS_NAME_MODAL}`), 'hide.bs.modal', this._hideModalHandler)
if (this.tip && this.tip.parentNode) { if (this.tip) {
this.tip.parentNode.removeChild(this.tip) this.tip.remove()
} }
if (this._popper) { if (this._popper) {
@ -314,8 +314,8 @@ class Tooltip extends BaseComponent {
return return
} }
if (this._hoverState !== HOVER_STATE_SHOW && tip.parentNode) { if (this._hoverState !== HOVER_STATE_SHOW) {
tip.parentNode.removeChild(tip) tip.remove()
} }
this._cleanTipClass() this._cleanTipClass()

6
js/src/util/backdrop.js
View File

@ -116,11 +116,7 @@ class Backdrop {
EventHandler.off(this._element, EVENT_MOUSEDOWN) EventHandler.off(this._element, EVENT_MOUSEDOWN)
const { parentNode } = this._getElement() this._element.remove()
if (parentNode) {
parentNode.removeChild(this._element)
}
this._isAppended = false this._isAppended = false
} }

2
js/src/util/sanitizer.js
View File

@ -108,7 +108,7 @@ export function sanitizeHtml(unsafeHtml, allowList, sanitizeFn) {
const elName = el.nodeName.toLowerCase() const elName = el.nodeName.toLowerCase()
if (!allowlistKeys.includes(elName)) { if (!allowlistKeys.includes(elName)) {
el.parentNode.removeChild(el) el.remove()
continue continue
} }