From 454cc55e313d29d886563b874abab33412f0d31d Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 9 Mar 2015 14:32:30 +0000 Subject: [PATCH] remove justified button groups --- docs/components/button-group.md | 66 --------------------------------- scss/_button-group.scss | 26 ------------- 2 files changed, 92 deletions(-) diff --git a/docs/components/button-group.md b/docs/components/button-group.md index 650949820f..dbb7b1a339 100644 --- a/docs/components/button-group.md +++ b/docs/components/button-group.md @@ -13,7 +13,6 @@ Group a series of buttons together on a single line with the button group. Add o

Ensure correct role and provide a label

In order for assistive technologies – such as screen readers – to convey that a series of buttons is grouped, an appropriate role attribute needs to be provided. For button groups, this would be role="group", while toolbars should have a role="toolbar".

-

One exception are groups which only contain a single control (for instance the justified button groups with <button> elements) or a dropdown.

In addition, groups and toolbars should be given an explicit label, as most assistive technologies will otherwise not announce them, despite the presence of the correct role attribute. In the examples provided here, we use aria-label, but alternatives such as aria-labelledby can also be used.

@@ -164,68 +163,3 @@ Make a set of buttons appear vertically stacked rather than horizontally. **Spli ... {% endhighlight %} - -### Justified button groups - -Make a group of buttons stretch at equal sizes to span the entire width of its parent. Also works with button dropdowns within the button group. - -
-

Handling borders

-

Due to the specific HTML and CSS used to justify buttons (namely display: table-cell), the borders between them are doubled. In regular button groups, margin-left: -1px is used to stack the borders instead of removing them. However, margin doesn't work with display: table-cell. As a result, depending on your customizations to Bootstrap, you may wish to remove or re-color the borders.

-
- -#### With `` elements - -Just wrap a series of `.btn`s in `.btn-group.btn-group-justified`. - -{% example html %} -
- -
- -
-{% endexample %} - -
-

Links acting as buttons

-

If the <a> elements are used to act as buttons – triggering in-page functionality, rather than navigating to another document or section within the current page – they should also be given an appropriate role="button".

-
- -#### With ` - -
- -
-
- -
- - -{% endexample %} diff --git a/scss/_button-group.scss b/scss/_button-group.scss index 6e8ae63ded..0e61f881a6 100644 --- a/scss/_button-group.scss +++ b/scss/_button-group.scss @@ -201,32 +201,6 @@ } -// Justified button groups -// ---------------------- - -.btn-group-justified { - display: table; - width: 100%; - table-layout: fixed; - border-collapse: separate; - - > .btn, - > .btn-group { - display: table-cell; - float: none; - width: 1%; - } - - > .btn-group .btn { - width: 100%; - } - - > .btn-group .dropdown-menu { - left: auto; - } -} - - // Checkbox and radio options // // In order to support the browser's form validation feedback, powered by the