From 03ec195974077caa54f13dfb89066d70f760a15d Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sat, 6 Feb 2016 12:28:18 -0800 Subject: [PATCH] linter overhaul --- docs/assets/scss/_ads.scss | 2 + docs/assets/scss/_callouts.scss | 8 +- docs/assets/scss/_content.scss | 2 +- docs/assets/scss/_masthead.scss | 2 + docs/assets/scss/_page-header.scss | 2 + docs/assets/scss/_responsive-tests.scss | 6 +- scss/.scss-lint.yml | 676 +++++++++++++----------- scss/_button-group.scss | 2 + scss/_buttons.scss | 2 + scss/_close.scss | 3 + scss/_forms.scss | 2 + scss/_input-group.scss | 2 + scss/_labels.scss | 2 + scss/_list-group.scss | 2 + scss/_navbar.scss | 2 + scss/_print.scss | 2 + scss/_progress.scss | 4 +- scss/_reboot.scss | 2 + scss/_tables.scss | 12 +- scss/utilities/_visibility.scss | 2 + 20 files changed, 422 insertions(+), 315 deletions(-) diff --git a/docs/assets/scss/_ads.scss b/docs/assets/scss/_ads.scss index 8876e5bfb6..405cac30ae 100644 --- a/docs/assets/scss/_ads.scss +++ b/docs/assets/scss/_ads.scss @@ -1,3 +1,5 @@ +// scss-lint:disable ImportantRule + // // Carbon ads // diff --git a/docs/assets/scss/_callouts.scss b/docs/assets/scss/_callouts.scss index 0ba52fd848..401bfd6f52 100644 --- a/docs/assets/scss/_callouts.scss +++ b/docs/assets/scss/_callouts.scss @@ -10,13 +10,16 @@ border-left-width: .25rem; border-radius: .25rem; } + .bd-callout h4 { margin-top: 0; margin-bottom: .25rem; } + .bd-callout p:last-child { margin-bottom: 0; } + .bd-callout code { border-radius: .25rem; } @@ -31,6 +34,7 @@ h4 { color: $color; } } -.bd-callout-info { @include bs-callout-variant($bd-info); } + +.bd-callout-info { @include bs-callout-variant($bd-info); } .bd-callout-warning { @include bs-callout-variant($bd-warning); } -.bd-callout-danger { @include bs-callout-variant($bd-danger); } +.bd-callout-danger { @include bs-callout-variant($bd-danger); } diff --git a/docs/assets/scss/_content.scss b/docs/assets/scss/_content.scss index 4e753dd04f..28f4cd4422 100644 --- a/docs/assets/scss/_content.scss +++ b/docs/assets/scss/_content.scss @@ -1,4 +1,4 @@ -// scss-lint:disable IdSelector +// scss-lint:disable IdSelector, NestingDepth, SelectorDepth // // Automatically style Markdown-based tables like a Bootstrap `.table`. diff --git a/docs/assets/scss/_masthead.scss b/docs/assets/scss/_masthead.scss index efbd5c649c..f0ebe93638 100644 --- a/docs/assets/scss/_masthead.scss +++ b/docs/assets/scss/_masthead.scss @@ -1,3 +1,5 @@ +// scss-lint:disable ImportantRule + .bd-masthead { position: relative; padding: 3rem ($grid-gutter-width / 2) 2rem; diff --git a/docs/assets/scss/_page-header.scss b/docs/assets/scss/_page-header.scss index 2934460a97..457d3fbef8 100644 --- a/docs/assets/scss/_page-header.scss +++ b/docs/assets/scss/_page-header.scss @@ -1,3 +1,5 @@ +// scss-lint:disable ImportantRule + .bd-pageheader { padding: 2rem ($grid-gutter-width / 2); margin-bottom: 1.5rem; diff --git a/docs/assets/scss/_responsive-tests.scss b/docs/assets/scss/_responsive-tests.scss index 0bdd6632db..79fe721bb7 100644 --- a/docs/assets/scss/_responsive-tests.scss +++ b/docs/assets/scss/_responsive-tests.scss @@ -1,3 +1,5 @@ +// scss-lint:disable ImportantRule + // // Responsive tests // @@ -20,11 +22,11 @@ .responsive-utilities td { text-align: center; } -.responsive-utilities td.is-visible { +.responsive-utilities .is-visible { color: #468847; background-color: #dff0d8 !important; } -.responsive-utilities td.is-hidden { +.responsive-utilities .is-hidden { color: #ccc; background-color: #f9f9f9 !important; } diff --git a/scss/.scss-lint.yml b/scss/.scss-lint.yml index f93f30d37c..f739a971a9 100644 --- a/scss/.scss-lint.yml +++ b/scss/.scss-lint.yml @@ -1,4 +1,16 @@ -scss_files: "scss/*.scss" +# Default application configuration that all configurations inherit from. +scss_files: + - "**/*.scss" + - "docs/assets/scss/**/*.scss" + +plugin_directories: ['.scss-linters'] + +# List of gem names to load custom linters from (make sure they are already +# installed) +plugin_gems: [] + +# Default severity of all linters. +severity: warning linters: BangFormat: @@ -6,8 +18,16 @@ linters: space_before_bang: true space_after_bang: false + BemDepth: + enabled: false + max_elements: 1 + BorderZero: enabled: true + convention: zero # or `none` + + ChainedClasses: + enabled: false ColorKeyword: enabled: true @@ -17,7 +37,10 @@ linters: Comment: enabled: true - exclude: ['_normalize.scss', 'bootstrap.scss'] + exclude: + - _normalize.scss + - bootstrap.scss + style: silent DebugStatement: enabled: true @@ -25,9 +48,11 @@ linters: DeclarationOrder: enabled: false + DisableLinterReason: + enabled: false + DuplicateProperty: enabled: true - exclude: ['mixins/_tab-focus.scss', '_reboot.scss'] ElsePlacement: enabled: true @@ -40,6 +65,9 @@ linters: EmptyRule: enabled: true + ExtendDirective: + enabled: false + FinalNewline: enabled: true present: true @@ -59,7 +87,7 @@ linters: enabled: true ImportantRule: - enabled: false + enabled: true ImportPath: enabled: true @@ -68,11 +96,12 @@ linters: Indentation: enabled: true + allow_non_nested_indentation: false character: space # or 'tab' width: 2 LeadingZero: - enabled: false + enabled: true style: exclude_zero # or 'include_zero' MergeableSelector: @@ -82,327 +111,350 @@ linters: NameFormat: enabled: true allow_leading_underscore: true - convention: hyphenated_lowercase # or 'BEM', or a regex pattern + convention: hyphenated_lowercase # or 'camel_case', or 'snake_case', or a regex pattern NestingDepth: - enabled: false + enabled: true + max_depth: 4 + ignore_parent_selectors: false PlaceholderInExtend: enabled: false + PropertyCount: + enabled: false + include_nested: false + max_properties: 10 + PropertySortOrder: enabled: true ignore_unspecified: false - severity: warning - exclude: ['_normalize.scss'] - order: [ - "position", - "top", - "right", - "bottom", - "left", - "z-index", - "-webkit-box-sizing", - "-moz-box-sizing", - "box-sizing", - "display", - "flex", - "flex-direction", - "flex-flow", - "flex-order", - "flex-pack", - "flex-align", - "float", - "width", - "min-width", - "max-width", - "height", - "min-height", - "max-height", - "padding", - "padding-top", - "padding-right", - "padding-bottom", - "padding-left", - "margin", - "margin-top", - "margin-right", - "margin-bottom", - "margin-left", - "overflow", - "overflow-x", - "overflow-y", - "-webkit-overflow-scrolling", - "-ms-overflow-x", - "-ms-overflow-y", - "-ms-overflow-style", - "clip", - "clear", - "font", - "font-family", - "font-size", - "font-style", - "font-weight", - "font-variant", - "font-size-adjust", - "font-stretch", - "font-effect", - "font-emphasize", - "font-emphasize-position", - "font-emphasize-style", - "font-smooth", - "-webkit-hyphens", - "-moz-hyphens", - "hyphens", - "line-height", - "color", - "text-align", - "-webkit-text-align-last", - "-moz-text-align-last", - "-ms-text-align-last", - "text-align-last", - "text-emphasis", - "text-emphasis-color", - "text-emphasis-style", - "text-emphasis-position", - "text-decoration", - "text-indent", - "text-justify", - "text-outline", - "-ms-text-overflow", - "text-overflow", - "text-overflow-ellipsis", - "text-overflow-mode", - "text-shadow", - "text-transform", - "text-wrap", - "-webkit-text-size-adjust", - "-ms-text-size-adjust", - "letter-spacing", - "-ms-word-break", - "word-break", - "word-spacing", - "-ms-word-wrap", - "word-wrap", - "-moz-tab-size", - "-o-tab-size", - "tab-size", - "white-space", - "vertical-align", - "list-style", - "list-style-position", - "list-style-type", - "list-style-image", - "pointer-events", - "-ms-touch-action", - "touch-action", - "cursor", - "visibility", - "zoom", - "table-layout", - "empty-cells", - "caption-side", - "border-spacing", - "border-collapse", - "content", - "quotes", - "counter-reset", - "counter-increment", - "resize", - "-webkit-user-select", - "-moz-user-select", - "-ms-user-select", - "-o-user-select", - "user-select", - "nav-index", - "nav-up", - "nav-right", - "nav-down", - "nav-left", - "background", - "background-color", - "background-image", - "-ms-filter:\\'progid:DXImageTransform.Microsoft.gradient", - "filter:progid:DXImageTransform.Microsoft.gradient", - "filter:progid:DXImageTransform.Microsoft.AlphaImageLoader", - "filter", - "background-repeat", - "background-attachment", - "background-position", - "background-position-x", - "background-position-y", - "-webkit-background-clip", - "-moz-background-clip", - "background-clip", - "background-origin", - "-webkit-background-size", - "-moz-background-size", - "-o-background-size", - "background-size", - "border", - "border-color", - "border-style", - "border-width", - "border-top", - "border-top-color", - "border-top-style", - "border-top-width", - "border-right", - "border-right-color", - "border-right-style", - "border-right-width", - "border-bottom", - "border-bottom-color", - "border-bottom-style", - "border-bottom-width", - "border-left", - "border-left-color", - "border-left-style", - "border-left-width", - "border-radius", - "border-top-left-radius", - "border-top-right-radius", - "border-bottom-right-radius", - "border-bottom-left-radius", - "-webkit-border-image", - "-moz-border-image", - "-o-border-image", - "border-image", - "-webkit-border-image-source", - "-moz-border-image-source", - "-o-border-image-source", - "border-image-source", - "-webkit-border-image-slice", - "-moz-border-image-slice", - "-o-border-image-slice", - "border-image-slice", - "-webkit-border-image-width", - "-moz-border-image-width", - "-o-border-image-width", - "border-image-width", - "-webkit-border-image-outset", - "-moz-border-image-outset", - "-o-border-image-outset", - "border-image-outset", - "-webkit-border-image-repeat", - "-moz-border-image-repeat", - "-o-border-image-repeat", - "border-image-repeat", - "outline", - "outline-width", - "outline-style", - "outline-color", - "outline-offset", - "-webkit-box-shadow", - "-moz-box-shadow", - "box-shadow", - "filter:progid:DXImageTransform.Microsoft.Alpha(Opacity", - "-ms-filter:\\'progid:DXImageTransform.Microsoft.Alpha", - "opacity", - "-ms-interpolation-mode", - "-webkit-transition", - "-moz-transition", - "-ms-transition", - "-o-transition", - "transition", - "-webkit-transition-delay", - "-moz-transition-delay", - "-ms-transition-delay", - "-o-transition-delay", - "transition-delay", - "-webkit-transition-timing-function", - "-moz-transition-timing-function", - "-ms-transition-timing-function", - "-o-transition-timing-function", - "transition-timing-function", - "-webkit-transition-duration", - "-moz-transition-duration", - "-ms-transition-duration", - "-o-transition-duration", - "transition-duration", - "-webkit-transition-property", - "-moz-transition-property", - "-ms-transition-property", - "-o-transition-property", - "transition-property", - "-webkit-transform", - "-moz-transform", - "-ms-transform", - "-o-transform", - "transform", - "-webkit-transform-origin", - "-moz-transform-origin", - "-ms-transform-origin", - "-o-transform-origin", - "transform-origin", - "-webkit-animation", - "-moz-animation", - "-ms-animation", - "-o-animation", - "animation", - "-webkit-animation-name", - "-moz-animation-name", - "-ms-animation-name", - "-o-animation-name", - "animation-name", - "-webkit-animation-duration", - "-moz-animation-duration", - "-ms-animation-duration", - "-o-animation-duration", - "animation-duration", - "-webkit-animation-play-state", - "-moz-animation-play-state", - "-ms-animation-play-state", - "-o-animation-play-state", - "animation-play-state", - "-webkit-animation-timing-function", - "-moz-animation-timing-function", - "-ms-animation-timing-function", - "-o-animation-timing-function", - "animation-timing-function", - "-webkit-animation-delay", - "-moz-animation-delay", - "-ms-animation-delay", - "-o-animation-delay", - "animation-delay", - "-webkit-animation-iteration-count", - "-moz-animation-iteration-count", - "-ms-animation-iteration-count", - "-o-animation-iteration-count", - "animation-iteration-count", - "-webkit-animation-direction", - "-moz-animation-direction", - "-ms-animation-direction", - "-o-animation-direction", - "animation-direction" - ] + min_properties: 2 + separate_groups: false + order: + - position + - top + - right + - bottom + - left + - z-index + - -webkit-box-sizing + - -moz-box-sizing + - box-sizing + - display + - flex + - flex-align + - flex-basis + - flex-direction + - flex-flow + - flex-grow + - flex-order + - flex-pack + - float + - width + - min-width + - max-width + - height + - min-height + - max-height + - padding + - padding-top + - padding-right + - padding-bottom + - padding-left + - margin + - margin-top + - margin-right + - margin-bottom + - margin-left + - overflow + - overflow-x + - overflow-y + - -webkit-overflow-scrolling + - -ms-overflow-x + - -ms-overflow-y + - -ms-overflow-style + - clip + - clear + - font + - font-family + - font-size + - font-style + - font-weight + - font-variant + - font-size-adjust + - font-stretch + - font-effect + - font-emphasize + - font-emphasize-position + - font-emphasize-style + - font-smooth + - -webkit-hyphens + - -moz-hyphens + - hyphens + - line-height + - color + - text-align + - -webkit-text-align-last + - -moz-text-align-last + - -ms-text-align-last + - text-align-last + - text-emphasis + - text-emphasis-color + - text-emphasis-style + - text-emphasis-position + - text-decoration + - text-indent + - text-justify + - text-outline + - -ms-text-overflow + - text-overflow + - text-overflow-ellipsis + - text-overflow-mode + - text-shadow + - text-transform + - text-wrap + - -webkit-text-size-adjust + - -ms-text-size-adjust + - letter-spacing + - -ms-word-break + - word-break + - word-spacing + - -ms-word-wrap + - word-wrap + - -moz-tab-size + - -o-tab-size + - tab-size + - white-space + - vertical-align + - list-style + - list-style-position + - list-style-type + - list-style-image + - pointer-events + - -ms-touch-action + - touch-action + - cursor + - visibility + - zoom + - table-layout + - empty-cells + - caption-side + - border-spacing + - border-collapse + - content + - quotes + - counter-reset + - counter-increment + - resize + - -webkit-user-select + - -moz-user-select + - -ms-user-select + - -o-user-select + - user-select + - nav-index + - nav-up + - nav-right + - nav-down + - nav-left + - background + - background-color + - background-image + - -ms-filter:\\'progid:DXImageTransform.Microsoft.gradient + - filter:progid:DXImageTransform.Microsoft.gradient + - filter:progid:DXImageTransform.Microsoft.AlphaImageLoader + - filter + - background-repeat + - background-attachment + - background-position + - background-position-x + - background-position-y + - -webkit-background-clip + - -moz-background-clip + - background-clip + - background-origin + - -webkit-background-size + - -moz-background-size + - -o-background-size + - background-size + - border + - border-color + - border-style + - border-width + - border-top + - border-top-color + - border-top-style + - border-top-width + - border-right + - border-right-color + - border-right-style + - border-right-width + - border-bottom + - border-bottom-color + - border-bottom-style + - border-bottom-width + - border-left + - border-left-color + - border-left-style + - border-left-width + - border-radius + - border-top-left-radius + - border-top-right-radius + - border-bottom-right-radius + - border-bottom-left-radius + - -webkit-border-image + - -moz-border-image + - -o-border-image + - border-image + - -webkit-border-image-source + - -moz-border-image-source + - -o-border-image-source + - border-image-source + - -webkit-border-image-slice + - -moz-border-image-slice + - -o-border-image-slice + - border-image-slice + - -webkit-border-image-width + - -moz-border-image-width + - -o-border-image-width + - border-image-width + - -webkit-border-image-outset + - -moz-border-image-outset + - -o-border-image-outset + - border-image-outset + - -webkit-border-image-repeat + - -moz-border-image-repeat + - -o-border-image-repeat + - border-image-repeat + - outline + - outline-width + - outline-style + - outline-color + - outline-offset + - -webkit-box-shadow + - -moz-box-shadow + - box-shadow + - filter:progid:DXImageTransform.Microsoft.Alpha(Opacity + - -ms-filter:\\'progid:DXImageTransform.Microsoft.Alpha + - opacity + - -ms-interpolation-mode + - -webkit-transition + - -moz-transition + - -ms-transition + - -o-transition + - transition + - -webkit-transition-delay + - -moz-transition-delay + - -ms-transition-delay + - -o-transition-delay + - transition-delay + - -webkit-transition-timing-function + - -moz-transition-timing-function + - -ms-transition-timing-function + - -o-transition-timing-function + - transition-timing-function + - -webkit-transition-duration + - -moz-transition-duration + - -ms-transition-duration + - -o-transition-duration + - transition-duration + - -webkit-transition-property + - -moz-transition-property + - -ms-transition-property + - -o-transition-property + - transition-property + - -webkit-transform + - -moz-transform + - -ms-transform + - -o-transform + - transform + - -webkit-transform-origin + - -moz-transform-origin + - -ms-transform-origin + - -o-transform-origin + - transform-origin + - -webkit-animation + - -moz-animation + - -ms-animation + - -o-animation + - animation + - -webkit-animation-name + - -moz-animation-name + - -ms-animation-name + - -o-animation-name + - animation-name + - -webkit-animation-duration + - -moz-animation-duration + - -ms-animation-duration + - -o-animation-duration + - animation-duration + - -webkit-animation-play-state + - -moz-animation-play-state + - -ms-animation-play-state + - -o-animation-play-state + - animation-play-state + - -webkit-animation-timing-function + - -moz-animation-timing-function + - -ms-animation-timing-function + - -o-animation-timing-function + - animation-timing-function + - -webkit-animation-delay + - -moz-animation-delay + - -ms-animation-delay + - -o-animation-delay + - animation-delay + - -webkit-animation-iteration-count + - -moz-animation-iteration-count + - -ms-animation-iteration-count + - -o-animation-iteration-count + - animation-iteration-count + - -webkit-animation-direction + - -moz-animation-direction + - -ms-animation-direction + - -o-animation-direction + PropertySpelling: enabled: true extra_properties: [] + disabled_properties: [] + + PropertyUnits: + enabled: true + global: [ + 'ch', 'em', 'ex', 'rem', # Font-relative lengths + 'cm', 'in', 'mm', 'pc', 'pt', 'px', 'q', # Absolute lengths + 'vh', 'vw', 'vmin', 'vmax', # Viewport-percentage lengths + 'deg', 'grad', 'rad', 'turn', # Angle + 'ms', 's', # Duration + 'Hz', 'kHz', # Frequency + 'dpi', 'dpcm', 'dppx', # Resolution + '%'] # Other + properties: {} PseudoElement: enabled: true QualifyingElement: - enabled: false + enabled: true allow_element_with_attribute: false allow_element_with_class: false allow_element_with_id: false SelectorDepth: - enabled: false + enabled: true + max_depth: 4 SelectorFormat: - enabled: true - convention: hyphenated_lowercase # or 'BEM', or 'snake_case', or 'camel_case', or a regex pattern - ignored_types: ["element"] + enabled: false + convention: hyphenated_lowercase # or 'strict_BEM', or 'hyphenated_BEM', or 'snake_case', or 'camel_case', or a regex pattern Shorthand: enabled: true + allowed_shorthands: [1, 2, 3] SingleLinePerProperty: - enabled: true + enabled: false allow_single_line_rule_sets: true SingleLinePerSelector: @@ -410,6 +462,7 @@ linters: SpaceAfterComma: enabled: false + style: one_space # or 'no_space', or 'at_least_one_space' SpaceAfterPropertyColon: enabled: true @@ -418,10 +471,17 @@ linters: SpaceAfterPropertyName: enabled: true + SpaceAfterVariableName: + enabled: true + + SpaceAroundOperator: + enabled: true + style: one_space # or 'at_least_one_space', or 'no_space' + SpaceBeforeBrace: enabled: true - style: space - allow_single_line_padding: true + style: space # or 'new_line' + allow_single_line_padding: false SpaceBetweenParens: enabled: true @@ -429,14 +489,20 @@ linters: StringQuotes: enabled: true - style: double_quotes + style: double_quotes # or double_quotes TrailingSemicolon: enabled: true + TrailingWhitespace: + enabled: true + TrailingZero: enabled: false + TransitionAll: + enabled: false + UnnecessaryMantissa: enabled: true @@ -449,11 +515,17 @@ linters: UrlQuotes: enabled: true - VendorPrefixes: + VariableForProperty: + enabled: false + properties: [] + + VendorPrefix: enabled: true identifier_list: base - include: [] - exclude: ['_normalize.scss'] + additional_identifiers: [] + excluded_identifiers: [] + exclude: + - _normalize.scss ZeroUnit: enabled: true diff --git a/scss/_button-group.scss b/scss/_button-group.scss index 3ef563f998..ff6c33f05f 100644 --- a/scss/_button-group.scss +++ b/scss/_button-group.scss @@ -1,3 +1,5 @@ +// scss-lint:disable QualifyingElement + // Make the div behave like a button .btn-group, .btn-group-vertical { diff --git a/scss/_buttons.scss b/scss/_buttons.scss index 1373218eb0..22148bef1c 100644 --- a/scss/_buttons.scss +++ b/scss/_buttons.scss @@ -1,3 +1,5 @@ +// scss-lint:disable QualifyingElement + // // Base styles // diff --git a/scss/_close.scss b/scss/_close.scss index 89e68a3817..f98d4c1dc0 100644 --- a/scss/_close.scss +++ b/scss/_close.scss @@ -19,6 +19,8 @@ // iOS requires the button element instead of an anchor tag. // If you want the anchor version, it requires `href="#"`. // See https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile + +// scss-lint:disable QualifyingElement button.close { padding: 0; cursor: pointer; @@ -26,3 +28,4 @@ button.close { border: 0; -webkit-appearance: none; } +// scss-lint:enable QualifyingElement diff --git a/scss/_forms.scss b/scss/_forms.scss index 28e0f26bdc..fd467030ad 100644 --- a/scss/_forms.scss +++ b/scss/_forms.scss @@ -1,3 +1,5 @@ +// scss-lint:disable QualifyingElement + // // Textual form controls // diff --git a/scss/_input-group.scss b/scss/_input-group.scss index f99bc3784a..8686069822 100644 --- a/scss/_input-group.scss +++ b/scss/_input-group.scss @@ -107,11 +107,13 @@ @include border-radius($border-radius-lg); } + // scss-lint:disable QualifyingElement // Nuke default margins from checkboxes and radios to vertically center within. input[type="radio"], input[type="checkbox"] { margin-top: 0; } + // scss-lint:enable QualifyingElement } diff --git a/scss/_labels.scss b/scss/_labels.scss index c58ddde17e..6dec516085 100644 --- a/scss/_labels.scss +++ b/scss/_labels.scss @@ -27,6 +27,7 @@ top: -1px; } +// scss-lint:disable QualifyingElement // Add hover effects, but only for links a.label { @include hover-focus { @@ -35,6 +36,7 @@ a.label { cursor: pointer; } } +// scss-lint:enable QualifyingElement // Pill labels // diff --git a/scss/_list-group.scss b/scss/_list-group.scss index f00afd1f7a..3d74da4cbc 100644 --- a/scss/_list-group.scss +++ b/scss/_list-group.scss @@ -44,6 +44,7 @@ // Use anchor or button elements instead of `li`s or `div`s to create interactive // list items. Includes an extra `.active` modifier class for selected items. +// scss-lint:disable QualifyingElement a.list-group-item, button.list-group-item { width: 100%; @@ -61,6 +62,7 @@ button.list-group-item { background-color: $list-group-hover-bg; } } +// scss-lint:enable QualifyingElement .list-group-item { // Disabled state diff --git a/scss/_navbar.scss b/scss/_navbar.scss index 5d894364c4..58da40c78b 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -117,6 +117,7 @@ } } +// scss-lint:disable ImportantRule // Custom override for .navbar-toggleable { &-xs { @@ -135,6 +136,7 @@ } } } +// scss-lint:enable ImportantRule // Navigation diff --git a/scss/_print.scss b/scss/_print.scss index 7820888118..ac1c3bba04 100644 --- a/scss/_print.scss +++ b/scss/_print.scss @@ -1,3 +1,5 @@ +// scss-lint:disable ImportantRule, QualifyingElement + // Source: https://github.com/h5bp/html5-boilerplate/blob/master/src/css/main.css // ========================================================================== diff --git a/scss/_progress.scss b/scss/_progress.scss index 8cac202ee0..b2bcb30568 100644 --- a/scss/_progress.scss +++ b/scss/_progress.scss @@ -3,8 +3,8 @@ // @keyframes progress-bar-stripes { - from { background-position: $spacer-y 0; } - to { background-position: 0 0; } + from { background-position: $spacer-y 0; } + to { background-position: 0 0; } } diff --git a/scss/_reboot.scss b/scss/_reboot.scss index ac3e83baa4..962eb78331 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -1,3 +1,5 @@ +// scss-lint:disable ImportantRule, QualifyingElement, DuplicateProperty + // Reboot // // Global resets to common HTML elements and more for easier usage by Bootstrap. diff --git a/scss/_tables.scss b/scss/_tables.scss index bf688a2c7e..c04e7c9b8a 100644 --- a/scss/_tables.scss +++ b/scss/_tables.scss @@ -108,7 +108,7 @@ .table-responsive { display: block; width: 100%; - min-height: 0.01%; // Workaround for IE9 bug (see https://github.com/twbs/bootstrap/issues/14837) + min-height: .01%; // Workaround for IE9 bug (see https://github.com/twbs/bootstrap/issues/14837) overflow-x: auto; // TODO: find out if we need this still. @@ -171,15 +171,14 @@ tbody, tfoot { &:last-child { - tr:last-child { - th, - td { - border-bottom: $table-border-width solid $table-border-color; - } + tr:last-child th, + tr:last-child td { + border-bottom: $table-border-width solid $table-border-color; } } } + // scss-lint:disable ImportantRule tr { float: left; @@ -189,4 +188,5 @@ border: $table-border-width solid $table-border-color; } } + // scss-lint:enable ImportantRule } diff --git a/scss/utilities/_visibility.scss b/scss/utilities/_visibility.scss index cdb1428698..63891677e4 100644 --- a/scss/utilities/_visibility.scss +++ b/scss/utilities/_visibility.scss @@ -1,3 +1,5 @@ +// scss-lint:disable ImportantRule + // // Visibility utilities //