From d9aa3c71fc7e9f11e97b6476ad68ff66627692a5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafa=C5=82=20Mikrut?= <mikrutrafal54@gmail.com>
Date: Thu, 29 Oct 2020 17:02:12 +0100
Subject: [PATCH] Fix some Cppcheck findings

---
 components/bl602/bl602_std/bl602_std/StdDriver/Src/bl602_glb.c | 2 +-
 components/fs/romfs/src/bl_romfs.c                             | 2 +-
 components/stage/blog/blog.c                                   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/components/bl602/bl602_std/bl602_std/StdDriver/Src/bl602_glb.c b/components/bl602/bl602_std/bl602_std/StdDriver/Src/bl602_glb.c
index 3c39e3a3..951b325b 100644
--- a/components/bl602/bl602_std/bl602_std/StdDriver/Src/bl602_glb.c
+++ b/components/bl602/bl602_std/bl602_std/StdDriver/Src/bl602_glb.c
@@ -2349,7 +2349,7 @@ GLB_GPIO_INT_CONTROL_Type GLB_Get_GPIO_IntCtlMod(GLB_GPIO_Type gpioPin)
 *******************************************************************************/
 BL_Err_Type GLB_GPIO_INT0_Callback_Install(GLB_GPIO_Type gpioPin,intCallback_Type* cbFun)
 {
-    if(gpioPin<32){
+    if(gpioPin<GLB_GPIO_INT0_NUM){
         glbGpioInt0CbfArra[gpioPin] = cbFun;
     }
     
diff --git a/components/fs/romfs/src/bl_romfs.c b/components/fs/romfs/src/bl_romfs.c
index 5dcbfafa..626037b6 100644
--- a/components/fs/romfs/src/bl_romfs.c
+++ b/components/fs/romfs/src/bl_romfs.c
@@ -572,7 +572,7 @@ static aos_dirent_t *romfs_readdir(file_t *fp, aos_dir_t *dir)
                 return NULL;
             } else {
                 while (1) {
-                    if ((dp->dir_cur_addr >= dp->dir_end_addr) || (dp->dir_cur_addr >= dp->dir_end_addr)){
+                    if ((dp->dir_cur_addr >= dp->dir_end_addr) || (dp->dir_cur_addr < dp->dir_start_addr)){
                         ROMFS_DUBUG("cur_addr = %p\r\n", dp->dir_cur_addr);
                         return NULL;
                     }
diff --git a/components/stage/blog/blog.c b/components/stage/blog/blog.c
index 7575802f..e5bc47f9 100644
--- a/components/stage/blog/blog.c
+++ b/components/stage/blog/blog.c
@@ -272,7 +272,7 @@ void blog_port_output(const char *log, size_t size) {
 size_t blog_strcpy(size_t cur_len, char *dst, const char *src) {
     const char *src_old = src;
 
-    if ((!src) || (!src)) {
+    if ((!dst) || (!src)) {
         __blog_printf("assert.\r\n");
         return 0;
     }