mirror/bl_iot_sdk
1
0
Fork 0
mirror of https://github.com/pine64/bl_iot_sdk.git synced 2024-07-05 04:29:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

vfs: Fix counting in inode_avail_count

Browse Source 
As seen in `inode_del` (and `inode_alloc`), a free (`NOT_INIT`) node can be found anywhere in `g_vfs_dev_nodes`; it’s a “sparse” list.
So when checking for free nodes, the iterating index variable (`e`) shall be used, not the counter (`count`). The code got that wrong.
For instance, if the first node is not available (type is not `VFS_TYPE_NOT_INIT`), then the function previously returned 0, no matter what, and was iterating the node list in vain.
This commit is contained in:
Paul Capron 2020-10-28 11:36:43 +01:00 committed by GitHub
parent 61d60a3dc0
commit 9d3c1f77da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
components/fs/vfs/src/vfs_inode.c
View File

@ -131,7 +131,7 @@ int inode_avail_count(void)
int e = 0;
for (; e < AOS_CONFIG_VFS_DEV_NODES; e++) {
if (g_vfs_dev_nodes[count].type == VFS_TYPE_NOT_INIT) {
if (g_vfs_dev_nodes[e].type == VFS_TYPE_NOT_INIT) {
count++;
}
}