aseprite/src/app/commands/cmd_layer_from_background.cpp
David Capello 8722c8ec16 Lock document in Tx() ctor (part of #2430)
This already fixes a lot of possible problems that can happen when a
script is running and modifying some part of a sprite that is being
backed up in a background thread.

We still need some work to being able to lock a sprite two or more
times in the same thread to write it. E.g. an app.transaction() should
lock the sprite for write access, but the script transaction function
could call a command, and that command could use a ContextWriter to
lock the sprite again. At the moment this is not possible because we
need a re-entrant RWLock implementation.
2023-12-27 11:05:15 -03:00

70 lines
1.8 KiB
C++

// Aseprite
// Copyright (C) 2020 Igara Studio S.A.
// Copyright (C) 2001-2018 David Capello
//
// This program is distributed under the terms of
// the End-User License Agreement for Aseprite.
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include "app/cmd/layer_from_background.h"
#include "app/commands/command.h"
#include "app/context_access.h"
#include "app/modules/gui.h"
#include "app/tx.h"
#include "doc/layer.h"
#include "doc/sprite.h"
namespace app {
class LayerFromBackgroundCommand : public Command {
public:
LayerFromBackgroundCommand();
protected:
bool onEnabled(Context* context) override;
void onExecute(Context* context) override;
};
LayerFromBackgroundCommand::LayerFromBackgroundCommand()
: Command(CommandId::LayerFromBackground(), CmdRecordableFlag)
{
}
bool LayerFromBackgroundCommand::onEnabled(Context* context)
{
return context->checkFlags(ContextFlags::ActiveDocumentIsWritable |
ContextFlags::HasActiveSprite |
ContextFlags::HasActiveLayer |
ContextFlags::ActiveLayerIsVisible |
ContextFlags::ActiveLayerIsEditable |
ContextFlags::ActiveLayerIsImage |
ContextFlags::ActiveLayerIsBackground) &&
// Isn't a reference layer
!context->checkFlags(ContextFlags::ActiveLayerIsReference);
}
void LayerFromBackgroundCommand::onExecute(Context* context)
{
ContextWriter writer(context);
Doc* document(writer.document());
{
Tx tx(writer, friendlyName());
tx(new cmd::LayerFromBackground(writer.layer()));
tx.commit();
}
#ifdef ENABLE_UI
if (context->isUIAvailable())
update_screen_for_document(document);
#endif
}
Command* CommandFactory::createLayerFromBackgroundCommand()
{
return new LayerFromBackgroundCommand;
}
} // namespace app