mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2024-12-29 18:20:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix failing ASSERT(i >= 0 && i < int(m_states.size())) in ListBox::selectChild()

Browse Source 
We receive kMouseMoveMessage as the first message of a multiselect
message in a ListBox when the kMouseDownMessage message is received by
a separator first e.g. if we click a separator from the Recover Files
tab and start dragging the mouse this assert was failing.
This commit is contained in:
David Capello 2023-04-17 22:32:22 -03:00
parent 79745756ef
commit f0e80f1b5a
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ui/listbox.cpp
View File

@ -81,6 +81,7 @@ void ListBox::selectChild(Widget* item, Message* msg)
// Save current state of all children when we start selecting // Save current state of all children when we start selecting
if (msg == nullptr || if (msg == nullptr ||
msg->type() == kMouseDownMessage || msg->type() == kMouseDownMessage ||
(msg->type() == kMouseMoveMessage && m_firstSelectedIndex < 0) ||
msg->type() == kKeyDownMessage) { msg->type() == kKeyDownMessage) {
m_firstSelectedIndex = itemIndex; m_firstSelectedIndex = itemIndex;
m_states.resize(children().size()); m_states.resize(children().size());
@ -256,8 +257,11 @@ bool ListBox::onProcessMessage(Message* msg)
return true; return true;
case kMouseUpMessage: case kMouseUpMessage:
if (hasCapture()) if (hasCapture()) {
releaseMouse(); releaseMouse();
m_firstSelectedIndex = -1;
m_lastSelectedIndex = -1;
}
return true; return true;
case kMouseWheelMessage: { case kMouseWheelMessage: {