mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2025-04-15 11:42:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert part of Sentry::areThereCrashesToReport() impl for macOS mainly

Browse Source 
Revert 00894101e08f4bb99b531fb28fc097beb326b72d as it was suggested in
this comment:

  https://github.com/getsentry/sentry-native/issues/930#issuecomment-1883739150

Only needed for macOS, but we can still use this on Windows just in
case (and use sentry_get_crashed_last_run() as a fast path if it
works).
This commit is contained in:
David Capello 2024-01-10 14:50:28 -03:00
parent b5b33ae09c
commit da7f51ee43
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/app/sentry_wrapper.cpp
View File

@ -99,7 +99,29 @@ bool Sentry::areThereCrashesToReport()
// As we don't use sentry_clear_crashed_last_run(), this will
// return 1 if the last run (or any previous run) has crashed.
return (sentry_get_crashed_last_run() == 1);
if (sentry_get_crashed_last_run() == 1)
return true;
// If the last_crash file exists, we can say that there are
// something to report (this file is created on Windows and Linux).
if (base::is_file(base::join_path(m_dbdir, "last_crash")))
return true;
// At least one .dmp file in the completed/ directory means that
// there was at least one crash in the past (this is for macOS).
for (auto f : base::list_files(base::join_path(m_dbdir, "completed"))) {
if (base::get_file_extension(f) == "dmp")
return true;
}
// In case that "last_crash" doesn't exist we can check for some
// .dmp file in the reports/ directory (it looks like the completed/
// directory is not generated on Windows).
for (auto f : base::list_files(base::join_path(m_dbdir, "reports"))) {
if (base::get_file_extension(f) == "dmp")
return true;
}
return false;
}
// static