mirror of
https://github.com/aseprite/aseprite.git
synced 2025-04-01 01:20:25 +00:00
[ci] Add commit linter action
This commit is contained in:
parent
aa152963d4
commit
ae63c633b4
72
.github/workflows/lint_commit.yml
vendored
Normal file
72
.github/workflows/lint_commit.yml
vendored
Normal file
@ -0,0 +1,72 @@
|
|||||||
|
# Based on SerenityOS commit linter:
|
||||||
|
# https://github.com/SerenityOS/serenity/blob/master/.github/workflows/lintcommits.yml
|
||||||
|
|
||||||
|
name: Commit linter
|
||||||
|
on: [pull_request_target]
|
||||||
|
jobs:
|
||||||
|
lint_commits:
|
||||||
|
runs-on: ubuntu-22.04
|
||||||
|
if: always() && github.repository == 'aseprite/aseprite'
|
||||||
|
steps:
|
||||||
|
- name: Lint PR commits
|
||||||
|
uses: actions/github-script@v7
|
||||||
|
with:
|
||||||
|
script: |
|
||||||
|
const rules = [
|
||||||
|
{
|
||||||
|
pattern: /^[^\r]*$/,
|
||||||
|
error: "Commit message contains CRLF line breaks (only unix-style LF linebreaks are allowed)",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
pattern: /^.+(\r?\n(\r?\n.*)*)?$/,
|
||||||
|
error: "Empty line between commit title and body is missing",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
pattern: /^.{0,72}(?:\r?\n(?:(.{0,72})|(.*?([a-z]+:\/\/)?(([a-zA-Z0-9_]|-)+\.)+[a-z]{2,}(:\d+)?([a-zA-Z_0-9@:%\+.~\?&/=]|-)+).*?))*$/,
|
||||||
|
error: "Commit message lines are too long (maximum allowed is 72 characters, except for URLs)",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
pattern: /^.+[^.\n](\r?\n.*)*$/,
|
||||||
|
error: "Commit title ends in a period",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
pattern: /^((?!Signed-off-by: )[\s\S])*$/,
|
||||||
|
error: "Commit body contains a Signed-off-by tag",
|
||||||
|
},
|
||||||
|
];
|
||||||
|
|
||||||
|
const { repository, pull_request } = context.payload;
|
||||||
|
|
||||||
|
// NOTE: This maxes out at 250 commits. If this becomes a problem, see:
|
||||||
|
// https://octokit.github.io/rest.js/v18#pulls-list-commits
|
||||||
|
const opts = github.rest.pulls.listCommits.endpoint.merge({
|
||||||
|
owner: repository.owner.login,
|
||||||
|
repo: repository.name,
|
||||||
|
pull_number: pull_request.number,
|
||||||
|
});
|
||||||
|
const commits = await github.paginate(opts);
|
||||||
|
|
||||||
|
const errors = [];
|
||||||
|
for (const { sha, commit: { message } } of commits) {
|
||||||
|
const commitErrors = [];
|
||||||
|
for (const { pattern, error } of rules) {
|
||||||
|
if (!pattern.test(message)) {
|
||||||
|
commitErrors.push(error);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (commitErrors.length > 0) {
|
||||||
|
const title = message.split("\n")[0];
|
||||||
|
errors.push([`${title} (${sha}):`, ...commitErrors].join("\n "));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (errors.length > 0) {
|
||||||
|
core.setFailed(`One or more of the commits in this PR do not match the code submission policy:\n\n${errors.join("\n")}`);
|
||||||
|
}
|
||||||
|
- name: Comment on PR
|
||||||
|
if: ${{ failure() && !github.event.pull_request.draft }}
|
||||||
|
uses: unsplash/comment-on-pr@a9bf050e744c8282dee4bb0dbcf063186d8316c4
|
||||||
|
env:
|
||||||
|
GITHUB_TOKEN: ${{ secrets.LINT_COMMIT_TOKEN }}
|
||||||
|
with:
|
||||||
|
msg: "Hi there!\n\nOne or more of the commit messages in this PR do not match our [code submission policy](https://github.com/aseprite/aseprite/blob/main/CONTRIBUTING.md), please check the `lint_commits` CI job for more details on which commits were flagged and why.\nPlease do not close this PR and open another, instead modify your commit message(s) with [git commit --amend](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message) and force push those changes to update this PR."
|
2
laf
2
laf
@ -1 +1 @@
|
|||||||
Subproject commit c82fd98b275cb25122106797af00feabc5015c7f
|
Subproject commit 7c2f0304293f0e6a42059608558d012adc66f46c
|
Loading…
x
Reference in New Issue
Block a user