mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2024-12-26 09:19:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix invalid key[] access in _handle_key_press()

Browse Source 
On Windows, if we pressed numpad dot key, all timers start working
incorrectly (e.g. animations couldn't be reproduced anymore.).
There was one report about this same issue on Mac OS X.
This commit is contained in:
David Capello 2015-09-11 15:12:21 -03:00
parent 83aa99a8e2
commit adce0b9569
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/allegro/src/keyboard.c
View File

@ -439,6 +439,11 @@ void _handle_key_press(int keycode, int scancode)
{
ASSERT(keyboard_driver);
if (scancode < 0 || scancode >= KEY_MAX) {
TRACE(PREFIX_I "Scancode out of range %d pressed\n", scancode);
return;
}
if ((keyboard_driver->poll) || (!keyboard_polled)) {
/* process immediately */
if (scancode > 0) {
@ -497,12 +502,8 @@ void _handle_key_release(int scancode)
repeat_scan = -1;
}
/* This is quite common if we press the numpad dot/delete. In debug
mode this asserts crashes the whole program. */
/* ASSERT(scancode < KEY_MAX); */
if (scancode >= KEY_MAX) {
TRACE(PREFIX_I "Scancode out of range %d\n", scancode);
if (scancode < 0 || scancode >= KEY_MAX) {
TRACE(PREFIX_I "Scancode out of range %d released\n", scancode);
return;
}