mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2025-01-01 18:00:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move rows array back to the beginning of ImageImpl buffer

Browse Source 
We are not sure, but due to new bug reports about a lagging mouse
movement (#4174), it might be because some memory cache issues: having
the rows array at the end of the pixels data might not be the best
decision.

It was moved at the end because we didn't need that rows array to be
aligned, only the pixels data. But with this patch we're trying to see
if this fixes the issue. So now we moved back the rows array at the
beginning of the image buffer as it was before aeeef8e255
This commit is contained in:
David Capello 2023-11-28 09:55:47 -03:00
parent 6f3e9e21ad
commit a8885105e9
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/doc/image_impl.h
View File

@ -32,8 +32,8 @@ namespace doc {
private:
ImageBufferPtr m_buffer;
address_t m_bits;
address_t* m_rows;
address_t m_bits;
inline address_t getLineAddress(int y) {
ASSERT(y >= 0 && y < height());
@ -64,7 +64,7 @@ namespace doc {
m_rowBytes = Traits::rowstride_bytes(width());
const std::size_t for_rows = sizeof(address_t) * height();
const std::size_t for_rows = doc_align_size(sizeof(address_t) * height());
const std::size_t for_pixels = m_rowBytes * height();
const std::size_t required_size = for_pixels + for_rows;
@ -76,13 +76,13 @@ namespace doc {
std::fill(m_buffer->buffer(),
m_buffer->buffer()+required_size, 0);
m_bits = (address_t)m_buffer->buffer();
m_rows = (address_t*)(m_buffer->buffer() + for_pixels);
m_rows = (address_t*)m_buffer->buffer();
m_bits = (address_t)(m_buffer->buffer() + for_rows);
address_t addr = m_bits;
auto addr = (uint8_t*)m_bits;
for (int y=0; y<height(); ++y) {
m_rows[y] = addr;
addr = (address_t)(((uint8_t*)addr) + m_rowBytes);
m_rows[y] = (address_t)addr;
addr += m_rowBytes;
}
}