diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml index 60fbee5c5..38114e47e 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy.yml @@ -5,6 +5,10 @@ on: - '**.cpp' - '**.h' - '.github/workflows/clang_tidy.yml' + +permissions: + contents: read + jobs: review: runs-on: ubuntu-latest @@ -12,19 +16,17 @@ jobs: - uses: actions/checkout@v4 with: submodules: 'recursive' - - uses: ZedThree/clang-tidy-review@v0.17.1 + - uses: ZedThree/clang-tidy-review@v0.14.0 id: review with: - token: ${{ secrets.CLANG_TIDY_TOKEN }} build_dir: build config_file: .clang-tidy + split_workflow: true apt_packages: | libc++-dev, libc++abi-dev, libpixman-1-dev, libfreetype6-dev, libharfbuzz-dev, zlib1g-dev, libx11-dev, libxcursor-dev, libxi-dev, libgl1-mesa-dev cmake_command: | cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DLAF_BACKEND=none -DCMAKE_EXPORT_COMPILE_COMMANDS=on - - uses: ZedThree/clang-tidy-review/upload@v0.17.1 + - uses: ZedThree/clang-tidy-review/upload@v0.14.0 id: upload-review - - if: steps.review.outputs.total_comments > 0 - run: exit 1 diff --git a/.github/workflows/clang_tidy_post.yml b/.github/workflows/clang_tidy_post.yml new file mode 100644 index 000000000..4ccf7845b --- /dev/null +++ b/.github/workflows/clang_tidy_post.yml @@ -0,0 +1,18 @@ +name: Post Clang Tidy Comments +on: + workflow_run: + workflows: ["Clang Tidy Diff"] + types: + - completed + +permissions: + checks: write + pull-requests: write + +jobs: + post-comments: + runs-on: ubuntu-latest + steps: + - uses: ZedThree/clang-tidy-review/post@v0.14.0 + with: + token: ${{ secrets.CLANG_TIDY_TOKEN }}