From 87f3b578e5512e657dcda1b7e05c3d1597910cb1 Mon Sep 17 00:00:00 2001 From: David Capello Date: Fri, 14 Apr 2017 15:28:46 -0300 Subject: [PATCH] Add a comment to ~PreviewEditor() --- src/app/ui/document_view.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/app/ui/document_view.cpp b/src/app/ui/document_view.cpp index 0dae2e37d..daac51bfb 100644 --- a/src/app/ui/document_view.cpp +++ b/src/app/ui/document_view.cpp @@ -155,14 +155,17 @@ class PreviewEditor : public Editor, public EditorCustomizationDelegate { public: PreviewEditor(Document* document) - : Editor(document, Editor::kShowOutside) // Don't show grid/mask in preview preview - { + : Editor(document, Editor::kShowOutside) { // Don't show grid/mask in preview preview setCustomizationDelegate(this); } - ~PreviewEditor() - { - setCustomizationDelegate(NULL); + ~PreviewEditor() { + // As we are destroying this instance, we have to remove it as the + // customization delegate. Editor::~Editor() will call + // setCustomizationDelegate(nullptr) too which triggers a + // EditorCustomizationDelegate::dispose() if the customization + // isn't nullptr. + setCustomizationDelegate(nullptr); } // EditorCustomizationDelegate implementation