mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2024-09-15 15:14:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid setting invalid frame on Editor in certain cases

Browse Source 
Playback is still buggy, and we need to fix some test cases, but this
is useful to fix a crash/assert fail if we try to set as active frame
something outside the valid range.
This commit is contained in:
David Capello 2022-10-24 16:19:25 -03:00
parent b21831561a
commit 69d3ada204
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/app/ui/editor/play_state.cpp
View File

@ -207,7 +207,11 @@ void PlayState::onPlaybackTick()
while (m_nextFrameTime <= 0) {
doc::frame_t frame = m_playback.nextFrame();
if (m_playback.isStopped()) {
if (m_playback.isStopped() ||
// TODO invalid frame from Playback::nextFrame(), in this way
// we avoid any kind of crash or assert fail
frame < 0 || frame > m_editor->sprite()->lastFrame()) {
TRACEARGS("!!! PlayState: invalid frame from Playback::nextFrame() frame=", frame);
m_editor->stop();
break;
}