mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2025-01-01 18:00:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add warning to ButtonSet::addItem() which is not safe to use w/a non-string literal

Browse Source
This commit is contained in:
David Capello 2023-02-27 11:57:56 -03:00
parent d88eb80fe6
commit 672f371622
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/app/ui/button_set.cpp
View File

@ -239,6 +239,9 @@ ButtonSet::Item* ButtonSet::addItem(Item* item, const char* styleId)
ButtonSet::Item* ButtonSet::addItem(Item* item, int hspan, int vspan, const char* styleId)
{
// TODO warning, here we're saving a copy of the styleId pointer,
// which if it's not a literal that lives enough for this
// lambda, it will crash the program
item->InitTheme.connect(
[item, styleId] {
ui::Style* style;