mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2025-03-14 04:19:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Possible fix for a crash transforming tilemaps in certain cases

Browse Source 
Crash report: https://igarastudio.zendesk.com/agent/tickets/2300
This commit is contained in:
David Capello 2021-06-01 10:43:03 -03:00
parent 7bcd511315
commit 649f187fc9
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/app/ui/editor/standby_state.cpp
View File

@ -747,11 +747,6 @@ void StandbyState::transformSelection(Editor* editor, MouseMessage* msg, HandleT
return;
try {
// Clear brush preview, as the extra cel will be replaced with the
// transformed image.
editor->brushPreview().hide();
EditorCustomizationDelegate* customization = editor->getCustomizationDelegate();
Site site = editor->getSite();
ImageRef tmpImage;
@ -765,6 +760,18 @@ void StandbyState::transformSelection(Editor* editor, MouseMessage* msg, HandleT
Preferences::instance().experimental.newBlend()));
}
ASSERT(tmpImage);
if (!tmpImage) {
// We've received a bug report with this case, we're not sure
// yet how to reproduce it. Probably new_tilemap_from_mask() can
// return nullptr (e.g. when site.cel() is nullptr?)
return;
}
// Clear brush preview, as the extra cel will be replaced with the
// transformed image.
editor->brushPreview().hide();
PixelsMovementPtr pixelsMovement(
new PixelsMovement(UIContext::instance(),
site,
@ -773,6 +780,7 @@ void StandbyState::transformSelection(Editor* editor, MouseMessage* msg, HandleT
"Transformation"));
// If the Ctrl key is pressed start dragging a copy of the selection
EditorCustomizationDelegate* customization = editor->getCustomizationDelegate();
if ((customization) &&
int(customization->getPressedKeyAction(KeyContext::TranslatingSelection) & KeyAction::CopySelection))
pixelsMovement->copyMask();