mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2024-09-15 15:14:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible memory leak setting invalid preference when loading a BoolPrefWidget from an XML file

Browse Source 
Reported in #2782
This commit is contained in:
David Capello 2021-06-23 08:54:26 -03:00
parent 89f8e6f275
commit 6157b004e4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/app/widget_loader.cpp
View File

@ -39,6 +39,7 @@
#include <cstdlib>
#include <cstring>
#include <limits>
#include <memory>
namespace app {
@ -202,9 +203,10 @@ Widget* WidgetLoader::convertXmlElementToWidget(const TiXmlElement* elem, Widget
if (!widget) {
// Automatic bind <check> widget with bool preference option
if (pref) {
auto prefWidget = new BoolPrefWidget<CheckBox>("");
std::unique_ptr<BoolPrefWidget<CheckBox>> prefWidget(
new BoolPrefWidget<CheckBox>(""));
prefWidget->setPref(pref);
widget = prefWidget;
widget = prefWidget.release();
}
else {
widget = new CheckBox("");