From 47ee01c1a089a4620ac3dbc877145184473ce133 Mon Sep 17 00:00:00 2001
From: David Capello <davidcapello@gmail.com>
Date: Sun, 20 Apr 2014 17:41:49 -0300
Subject: [PATCH] Proper handling of HRESULTs

---
 src/allegro/src/win/wddwin.c |  2 +-
 src/app/file_system.cpp      | 45 ++++++++++++++++++++++--------------
 2 files changed, 29 insertions(+), 18 deletions(-)

diff --git a/src/allegro/src/win/wddwin.c b/src/allegro/src/win/wddwin.c
index 3f8c75ed1..37bf7644f 100644
--- a/src/allegro/src/win/wddwin.c
+++ b/src/allegro/src/win/wddwin.c
@@ -205,7 +205,7 @@ static void paint_win(RECT *rect)
    /* we may have lost the DirectDraw surfaces
     * (e.g after the monitor has gone to low power)
     */
-   if (IDirectDrawSurface2_IsLost(gfx_directx_primary_surface->id))
+   if (IDirectDrawSurface2_IsLost(gfx_directx_primary_surface->id) == DDERR_SURFACELOST)
       switch_in_win();
 
    /* clip the rectangle */
diff --git a/src/app/file_system.cpp b/src/app/file_system.cpp
index 5e511ad78..342f752e2 100644
--- a/src/app/file_system.cpp
+++ b/src/app/file_system.cpp
@@ -204,10 +204,14 @@ FileSystemModule::FileSystemModule()
 
 #ifdef USE_PIDLS
   /* get the IMalloc interface */
-  SHGetMalloc(&shl_imalloc);
+  HRESULT hr = SHGetMalloc(&shl_imalloc);
+  if (hr != S_OK)
+    throw new std::runtime_error("Error initializing file system. Report this problem. (SHGetMalloc failed.)");
 
   /* get desktop IShellFolder interface */
-  SHGetDesktopFolder(&shl_idesktop);
+  hr = SHGetDesktopFolder(&shl_idesktop);
+  if (hr != S_OK)
+    throw new std::runtime_error("Error initializing file system. Report this problem. (SHGetDesktopFolder failed.)");
 #endif
 
   // first version of the file system
@@ -321,7 +325,7 @@ IFileItem* FileSystemModule::getFileItemFromPath(const base::string& path)
 
 #ifdef USE_PIDLS
   {
-    ULONG cbEaten;
+    ULONG cbEaten = 0UL;
     LPITEMIDLIST fullpidl = NULL;
     SFGAOF attrib = SFGAO_FOLDER;
 
@@ -443,24 +447,27 @@ const FileItemList& FileItem::getChildren()
 #ifdef USE_PIDLS
     {
       IShellFolder* pFolder = NULL;
+      HRESULT hr;
 
       if (this == rootitem)
         pFolder = shl_idesktop;
-      else
-        shl_idesktop->BindToObject(this->fullpidl,
-                                   NULL,
-                                   IID_IShellFolder,
-                                   (LPVOID *)&pFolder);
+      else {
+        hr = shl_idesktop->BindToObject(this->fullpidl,
+          NULL, IID_IShellFolder, (LPVOID *)&pFolder);
+
+        if (hr != S_OK)
+          pFolder = NULL;
+      }
 
       if (pFolder != NULL) {
         IEnumIDList *pEnum = NULL;
         ULONG c, fetched;
 
         /* get the interface to enumerate subitems */
-        pFolder->EnumObjects(win_get_window(),
-                             SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnum);
+        hr = pFolder->EnumObjects(win_get_window(),
+          SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnum);
 
-        if (pEnum != NULL) {
+        if (hr == S_OK && pEnum != NULL) {
           LPITEMIDLIST itempidl[256];
           SFGAOF attribs[256];
 
@@ -534,7 +541,9 @@ const FileItemList& FileItem::getChildren()
     for (it=this->children.begin();
          it!=this->children.end(); ) {
       child = static_cast<FileItem*>(*it);
-      if (child->removed) {
+      ASSERT(child != NULL);
+
+      if (child && child->removed) {
         it = this->children.erase(it);
 
         fileitems_map->erase(fileitems_map->find(child->keyname));
@@ -709,15 +718,16 @@ static void update_by_pidl(FileItem* fileitem)
   STRRET strret;
   WCHAR pszName[MAX_PATH];
   IShellFolder *pFolder = NULL;
+  HRESULT hr;
 
   if (fileitem == rootitem)
     pFolder = shl_idesktop;
   else {
     ASSERT(fileitem->parent);
-    shl_idesktop->BindToObject(fileitem->parent->fullpidl,
-                               NULL,
-                               IID_IShellFolder,
-                               (LPVOID *)&pFolder);
+    hr = shl_idesktop->BindToObject(fileitem->parent->fullpidl,
+      NULL, IID_IShellFolder, (LPVOID *)&pFolder);
+    if (hr != S_OK)
+      pFolder = NULL;
   }
 
   /****************************************/
@@ -894,7 +904,8 @@ static base::string get_key_for_pidl(LPITEMIDLIST pidl)
     if (shl_idesktop->GetDisplayNameOf(pidl,
                                        SHGDN_INFOLDER | SHGDN_FORPARSING,
                                        &strret) == S_OK) {
-      StrRetToBuf(&strret, pidl, pszName, MAX_PATH);
+      if (StrRetToBuf(&strret, pidl, pszName, MAX_PATH) != S_OK)
+        pszName[0] = 0;
 
       //PRINTF("FS: + %s\n", pszName);