mirror/aseprite
1
0
Fork 0
mirror of https://github.com/aseprite/aseprite.git synced 2025-01-01 18:00:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix segfault with -save-as between gif -> qoi from CLI

Browse Source 
This can happen when any fatal error happens in
createSaveDocumentOperation(). The function must return nullptr to
stop the operation and avoid the regular saving process. This is
already checked in the GUI, but we have to do the same when the fatal
error happens from the CLI.
This commit is contained in:
David Capello 2023-02-02 11:50:34 -03:00
parent 45ce79e594
commit 28749edf10
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/app/file/file.cpp
View File

@ -1,5 +1,5 @@
// Aseprite
// Copyright (C) 2018-2022 Igara Studio S.A.
// Copyright (C) 2018-2023 Igara Studio S.A.
// Copyright (C) 2001-2018 David Capello
//
// This program is distributed under the terms of
@ -643,8 +643,10 @@ FileOp* FileOp::createSaveDocumentOperation(const Context* context,
else
#endif // ENABLE_UI
if (fatal) {
fop->setError(warnings.c_str());
return fop.release();
// Return nullptr as the operation cannot be done because a
// fatal error/conversion was found, e.g. the format doesn't
// support the color mode of the sprite.
return nullptr;
}
}