Avoid problems regenerating brush boundaries when the brush image ptr addresses are the same

src/app/ui/editor/cursor.cpp

@@ -55,10 +55,10 @@ using namespace ui;
 static struct {
   int nseg;
   BoundSeg* seg;
-  Image* brush_image;
+  int brush_gen;
   int brush_width;
   int brush_height;
-} cursor_bound = { 0, nullptr, nullptr, 0, 0 };
+} cursor_bound = { 0, nullptr, 0, 0, 0 };
 
 enum {
   CURSOR_THINCROSS   = 1,
@@ -79,7 +79,7 @@ static gfx::Region old_clipping_region;
 
 static gfx::Rect lastBrushBounds;
 
-static void generate_cursor_boundaries(Editor* editor);
+static void generate_cursor_boundaries();
 
 static void trace_thincross_pixels(ui::Graphics* g, Editor* editor, const gfx::Point& pt, gfx::Color color, Editor::PixelDelegate pixel);
 static void trace_thickcross_pixels(ui::Graphics* g, Editor* editor, const gfx::Point& pt, gfx::Color color, int thickness, Editor::PixelDelegate pixel);
@@ -172,7 +172,7 @@ void Editor::drawBrushPreview(const gfx::Point& pos)
 
   // For cursor type 'bounds' we have to generate cursor boundaries
   if (cursor_type & CURSOR_BRUSHBOUNDS)
-    generate_cursor_boundaries(this);
+    generate_cursor_boundaries();
 
   // Draw pixel/brush preview
   if (cursor_type & CURSOR_THINCROSS && m_state->requireBrushPreview()) {
@@ -292,41 +292,40 @@ bool Editor::doesBrushPreviewNeedSubpixel()
 
 //////////////////////////////////////////////////////////////////////
 
-static void generate_cursor_boundaries(Editor* editor)
+static void generate_cursor_boundaries()
 {
   Brush* brush = get_current_brush();
 
-  if (!cursor_bound.seg || cursor_bound.brush_image != brush->image()) {
-    Image* brush_image = brush->image();
-    int w = brush_image->width();
-    int h = brush_image->height();
+  if (cursor_bound.seg &&
+      cursor_bound.brush_gen == brush->gen())
+    return;
 
-    cursor_bound.brush_image = brush_image;
-    cursor_bound.brush_width = w;
-    cursor_bound.brush_height = h;
+  Image* brush_image = brush->image();
+  int w = brush_image->width();
+  int h = brush_image->height();
 
-    if (cursor_bound.seg)
-      base_free(cursor_bound.seg);
+  cursor_bound.brush_gen = brush->gen();
+  cursor_bound.brush_width = w;
+  cursor_bound.brush_height = h;
 
-    ImageRef mask;
-    if (brush_image->pixelFormat() != IMAGE_BITMAP) {
-      mask.reset(Image::create(IMAGE_BITMAP, w, h));
+  ImageRef mask;
+  if (brush_image->pixelFormat() != IMAGE_BITMAP) {
+    mask.reset(Image::create(IMAGE_BITMAP, w, h));
 
-      LockImageBits<BitmapTraits> bits(mask.get());
-      auto pos = bits.begin();
-      for (int v=0; v<h; ++v) {
-        for (int u=0; u<w; ++u) {
-          *pos = get_pixel(brush_image, u, v);
-          ++pos;
-        }
+    LockImageBits<BitmapTraits> bits(mask.get());
+    auto pos = bits.begin();
+    for (int v=0; v<h; ++v) {
+      for (int u=0; u<w; ++u) {
+        *pos = get_pixel(brush_image, u, v);
+        ++pos;
       }
     }
-
-    cursor_bound.seg = find_mask_boundary(
-      (mask ? mask.get(): brush_image),
-      &cursor_bound.nseg,
-      IgnoreBounds, 0, 0, 0, 0);
   }
+
+  cursor_bound.seg = find_mask_boundary(
+    (mask ? mask.get(): brush_image),
+    &cursor_bound.nseg,
+    IgnoreBounds, 0, 0, 0, 0);
 }
 
 void Editor::forEachBrushPixel(

src/doc/brush.cpp

@@ -19,12 +19,15 @@
 
 namespace doc {
 
+static int generation = 0;
+
 Brush::Brush()
 {
   m_type = kCircleBrushType;
   m_size = 1;
   m_angle = 0;
   m_pattern = BrushPattern::DEFAULT;
+  m_gen = 0;
 
   regenerate();
 }
@@ -35,6 +38,7 @@ Brush::Brush(BrushType type, int size, int angle)
   m_size = size;
   m_angle = angle;
   m_pattern = BrushPattern::DEFAULT;
+  m_gen = 0;
 
   regenerate();
 }
@@ -47,6 +51,7 @@ Brush::Brush(const Brush& brush)
   m_image = brush.m_image;
   m_pattern = brush.m_pattern;
   m_patternOrigin = brush.m_patternOrigin;
+  m_gen = 0;
 
   regenerate();
 }
@@ -89,6 +94,7 @@ void Brush::setImage(const Image* image)
 // Cleans the brush's data (image and region).
 void Brush::clean()
 {
+  m_gen = ++generation;
   m_image.reset();
 }
 

src/doc/brush.h

@@ -32,6 +32,7 @@ namespace doc {
     int size() const { return m_size; }
     int angle() const { return m_angle; }
     Image* image() const { return m_image.get(); }
+    int gen() const { return m_gen; }
 
     BrushPattern pattern() const { return m_pattern; }
     gfx::Point patternOrigin() const { return m_patternOrigin; }
@@ -60,6 +61,7 @@ namespace doc {
     gfx::Rect m_bounds;
     BrushPattern m_pattern;               // How the image should be replicated
     gfx::Point m_patternOrigin;           // From what position the brush was taken
+    int m_gen;
   };
 
   typedef base::SharedPtr<Brush> BrushRef;