Replace some UI_FOREACH_WIDGET() with range-based for loops

This commit is contained in:
David Capello 2015-06-29 15:42:34 -03:00
parent 8f66e75cb0
commit 0b0cb56c1e
3 changed files with 19 additions and 19 deletions

View File

@ -557,11 +557,11 @@ void Manager::setFocus(Widget* widget)
Message* msg = new Message(kFocusLeaveMessage);
UI_FOREACH_WIDGET(focus_parents, it) {
for (Widget* parent1 : focus_parents) {
if (widget) {
UI_FOREACH_WIDGET(widget_parents, it2) {
if (*it == *it2) {
common_parent = *it;
for (Widget* parent2 : widget_parents) {
if (parent1 == parent2) {
common_parent = parent1;
break;
}
}
@ -569,9 +569,9 @@ void Manager::setFocus(Widget* widget)
break;
}
if ((*it)->hasFocus()) {
(*it)->disableFlags(HAS_FOCUS);
msg->addRecipient(*it);
if (parent1->hasFocus()) {
parent1->disableFlags(HAS_FOCUS);
msg->addRecipient(parent1);
}
}
@ -638,11 +638,11 @@ void Manager::setMouse(Widget* widget)
Message* msg = new Message(kMouseLeaveMessage);
UI_FOREACH_WIDGET(mouse_parents, it) {
for (Widget* parent1 : mouse_parents) {
if (widget) {
UI_FOREACH_WIDGET(widget_parents, it2) {
if (*it == *it2) {
common_parent = *it;
for (Widget* parent2 : widget_parents) {
if (parent1 == parent2) {
common_parent = parent1;
break;
}
}
@ -650,9 +650,9 @@ void Manager::setMouse(Widget* widget)
break;
}
if ((*it)->hasMouse()) {
(*it)->disableFlags(HAS_MOUSE);
msg->addRecipient(*it);
if (parent1->hasMouse()) {
parent1->disableFlags(HAS_MOUSE);
msg->addRecipient(parent1);
}
}

View File

@ -59,8 +59,8 @@ bool TooltipManager::onProcessMessage(Message* msg)
switch (msg->type()) {
case kMouseEnterMessage: {
UI_FOREACH_WIDGET(msg->recipients(), itWidget) {
Tips::iterator it = m_tips.find(*itWidget);
for (Widget* widget : msg->recipients()) {
Tips::iterator it = m_tips.find(widget);
if (it != m_tips.end()) {
m_target.widget = it->first;
m_target.tipInfo = it->second;

View File

@ -410,14 +410,14 @@ Widget* Widget::getPreviousSibling()
Widget* Widget::pick(const gfx::Point& pt)
{
Widget* inside, *picked = NULL;
Widget* inside, *picked = nullptr;
if (!hasFlags(HIDDEN) && // Is visible
getBounds().contains(pt)) { // The point is inside the bounds
picked = this;
UI_FOREACH_WIDGET(m_children, it) {
inside = (*it)->pick(pt);
for (Widget* child : m_children) {
inside = child->pick(pt);
if (inside) {
picked = inside;
break;