We have to list commands in Keyboard Shortcuts regardless of context

Removed KeyContext param from Command::isListed().

src/app/commands/cmd_flip.h

@@ -26,7 +26,7 @@ namespace app {
     bool onEnabled(Context* context) override;
     void onExecute(Context* context) override;
     std::string onGetFriendlyName() const override;
-    bool isListed(const Params& params, const KeyContext& context) const override {
+    bool isListed(const Params& params) const override {
       return !params.empty();
     }
 

src/app/commands/cmd_goto_frame.cpp

@@ -87,9 +87,6 @@ protected:
 
     return (frame > 0 ? frame-1: last);
   }
-  bool isListed(const Params& params, const KeyContext& context) const override {
-    return context == KeyContext::Normal;
-  }
 };
 
 class GotoNextFrameCommand : public GotoCommand {
@@ -103,9 +100,6 @@ protected:
 
     return (frame < last ? frame+1: 0);
   }
-  bool isListed(const Params& params, const KeyContext& context) const override {
-    return context == KeyContext::Normal;
-  }
 };
 
 class GotoNextFrameWithSameTagCommand : public GotoCommand {

src/app/commands/cmd_launch.cpp

@@ -25,8 +25,8 @@ protected:
   void onLoadParams(const Params& params) override;
   void onExecute(Context* context) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override {
+  bool isListed(const Params& params) const override {
-    return params.get("path") != "";
+    return !params.get("path").empty();
   }
 
 private:

src/app/commands/cmd_layer_properties.cpp

@@ -56,9 +56,6 @@ public:
 protected:
   bool onEnabled(Context* context) override;
   void onExecute(Context* context) override;
-  bool isListed(const Params& params, const KeyContext& context) const override {
-    return context == KeyContext::Normal;
-  }
 };
 
 class LayerPropertiesWindow;

src/app/commands/cmd_modify_selection.cpp

@@ -45,9 +45,7 @@ protected:
   bool onEnabled(Context* context) override;
   void onExecute(Context* context) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override {
+  bool isListed(const Params& params) const override { return !params.empty(); }
-    return !params.empty();
-  }
 
 private:
   std::string getActionName() const;

src/app/commands/cmd_open_browser.cpp

@@ -25,9 +25,7 @@ protected:
   void onLoadParams(const Params& params) override;
   void onExecute(Context* context) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override {
+  bool isListed(const Params& params) const override { return !params.empty(); }
-    return !params.empty();
-  }
 
 private:
   std::string m_filename;

src/app/commands/cmd_run_script.cpp

@@ -39,10 +39,7 @@ protected:
   void onLoadParams(const Params& params) override;
   void onExecute(Context* context) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override
+  bool isListed(const Params& params) const override { return !params.empty(); }
-  {
-    return !params.empty();
-  }
 
 private:
   std::string m_filename;

src/app/commands/cmd_select_palette.cpp

@@ -45,10 +45,7 @@ protected:
   void onLoadParams(const Params& params) override;
   void onExecute(Context* context) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override
+  bool isListed(const Params& params) const override { return !params.empty(); }
-  {
-    return !params.empty();
-  }
 
 private:
   void selectTiles(const Layer* layer,

src/app/commands/cmd_set_loop_section.cpp

@@ -34,9 +34,6 @@ protected:
   void onLoadParams(const Params& params) override;
   bool onEnabled(Context* context) override;
   void onExecute(Context* context) override;
-  bool isListed(const Params& params, const KeyContext& context) const override {
-    return context == KeyContext::FramesSelection;
-  }
 
   Action m_action;
   doc::frame_t m_begin, m_end;

src/app/commands/cmd_set_palette_entry_size.cpp

@@ -25,10 +25,7 @@ protected:
   bool onChecked(Context* context) override;
   void onExecute(Context* context) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override
+  bool isListed(const Params& params) const override { return !params.empty(); }
-  {
-    return !params.empty();
-  }
 
 private:
   int m_size;

src/app/commands/cmd_tiled_mode.cpp

@@ -29,10 +29,7 @@ protected:
   bool onChecked(Context* context) override;
   void onExecute(Context* context) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override
+  bool isListed(const Params& params) const override { return !params.empty(); }
-  {
-    return !params.empty();
-  }
 
   filters::TiledMode m_mode;
 };

src/app/commands/command.h

@@ -37,13 +37,10 @@ namespace app {
     void loadParams(const Params& params);
     bool isEnabled(Context* context);
     bool isChecked(Context* context);
-    // Not all Commands must be listed on KeyBoard Shortcut list, so
+
-    // this function returns if a key command should be listed or not.
+    // Returns true if the command must be displayed in the Keyboard
-    // Used on 'cmd_keyboard_shorcuts.cpp'.
+    // Shortcuts list.
-    virtual bool isListed(const Params& params, const KeyContext& context) const
+    virtual bool isListed(const Params& params) const { return true; }
-    {
-      return true;
-    }
 
   protected:
     virtual bool onNeedsParams() const;

src/app/commands/screenshot.cpp

@@ -54,9 +54,7 @@ public:
 protected:
   void onExecute(Context* ctx) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override {
+  bool isListed(const Params& params) const override { return !params.empty(); }
-    return !params.empty();
-  }
 };
 
 ScreenshotCommand::ScreenshotCommand()

src/app/commands/set_playback_speed.cpp

@@ -26,10 +26,7 @@ protected:
   bool onChecked(Context* ctx) override;
   void onExecute(Context* ctx) override;
   std::string onGetFriendlyName() const override;
-  bool isListed(const Params& params, const KeyContext& context) const override
+  bool isListed(const Params& params) const override { return !params.empty(); }
-  {
-    return !params.empty();
-  }
 };
 
 SetPlaybackSpeedCommand::SetPlaybackSpeedCommand()

src/app/commands/tileset_mode.cpp

@@ -54,9 +54,7 @@ protected:
     return Strings::commands_TilesetMode(mode);
   }
 
-  bool isListed(const Params& params, const KeyContext& context) const override {
+  bool isListed(const Params& params) const override { return !params.empty(); }
-    return !params.empty();
-  }
 
 private:
   TilesetMode m_mode;

src/app/ui/keyboard_shortcuts.cpp

@@ -496,7 +496,7 @@ bool Key::isLooselyPressed() const
 
 bool Key::isListed() const
 {
-  return type() != KeyType::Command || !command()->isListed(params(), keycontext());
+  return type() != KeyType::Command || !command()->isListed(params());
 }
 
 bool Key::hasAccel(const ui::Accelerator& accel) const