From 41e6344995a8a1623fa220f3230ac465f7e9e26e Mon Sep 17 00:00:00 2001
From: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Date: Sun, 16 Jan 2022 14:05:18 -0500
Subject: [PATCH 1/2] Update bug-report.yml

- Use form instead of template
---
 .github/ISSUE_TEMPLATE/bug-report.md  | 37 ------------
 .github/ISSUE_TEMPLATE/bug-report.yml | 82 +++++++++++++++++++++++++++
 2 files changed, 82 insertions(+), 37 deletions(-)
 delete mode 100644 .github/ISSUE_TEMPLATE/bug-report.md
 create mode 100644 .github/ISSUE_TEMPLATE/bug-report.yml

diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md
deleted file mode 100644
index 4da04b37..00000000
--- a/.github/ISSUE_TEMPLATE/bug-report.md
+++ /dev/null
@@ -1,37 +0,0 @@
----
-name: Bug report
-about: Create a report to help us improve
-title: ""
-labels: ''
-assignees: ''
-
----
-
-**Describe the bug**
-<!-- A clear and concise description of what the bug is. -->
-
-**To Reproduce**
-<!-- Steps to reproduce the behavior: -->
-1. [e.g. Go to '...']
-2. [e.g. Click on '....']
-3. [e.g. Scroll down to '....']
-4. [e.g. See error]
-
-**Expected behavior**
-<!-- A clear and concise description of what you expected to happen. -->
-
-**Screenshots**
-<!-- If applicable, add screenshots to help explain your problem. -->
-
-**Host**
-<!-- Please complete the following information -->
- - OS: [e.g. Windows, Linux, Mac... include build/distro details]
- - Architecture: [e.g. 32 bit, 64 bit, arm]
- - Version: [e.g. 0.11.1]
- - GPU Type: [e.g. Intel, AMD, Nvidia]
- - GPU Model:
- - GPU Driver/Mesa Version:
- - Capture method (Linux only): [e.g. PipeWire/KVM/X11]
-
-**Additional context**
-<!-- Add any other context about the problem here. -->
diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml
new file mode 100644
index 00000000..a9c38290
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/bug-report.yml
@@ -0,0 +1,82 @@
+name: Bug Report
+description: Create a bug report to help us improve.
+body:
+  - type: markdown
+    attributes:
+      value: >
+        **THIS IS NOT THE PLACE TO ASK FOR SUPPORT!**
+        Please use [Github Discussions](https://github.com/SunshineStream/Sunshine/discussions) for support issues.
+  - type: textarea
+    id: description
+    attributes:
+      label: Describe the Bug
+      description: A clear and concise description of the bug.
+    validations:
+      required: true
+  - type: textarea
+    id: expected
+    attributes:
+      label: Expected Behavior
+      description: A clear and concise description of what you expected to happen.
+  - type: textarea
+    id: additional
+    attributes:
+      label: Additional Context
+      description: Add any other context about the bug here.
+  - type: input
+    id: os
+    attributes:
+      label: Sunshine Host Operating System and Version
+      placeholder: eg. Windows 10, macOS 10.15, Ubuntu 20.04, etc.
+    validations:
+      required: true
+  - type: input
+    id: architecture
+    attributes:
+      label: Architecture
+      placeholder: e.g. 32 bit, 64 bit, arm
+    validations:
+      required: true
+  - type: input
+    id: version
+    attributes:
+      label: Sunshine Version
+      placeholder: eg. 0.11.1
+    validations:
+      required: true
+  - type: input
+    id: graphics_type
+    attributes:
+      label: GPU Type
+      description: The type of the installed graphics card.
+      placeholder: e.g. Intel, AMD, Nvidia
+    validations:
+      required: true
+  - type: input
+    id: graphics_model
+    attributes:
+      label: GPU Model
+      description: The model of the installed graphics card.
+      placeholder: e.g. GeForce RTX 2080 SUPER
+    validations:
+      required: true
+  - type: input
+    id: graphics_driver
+    attributes:
+      label: GPU Driver/Mesa Version
+      description: The driver/mesa version of the installed graphics card.
+      placeholder: e.g. 497.29
+    validations:
+      required: true
+  - type: input
+    id: capture_method
+    attributes:
+      label: Capture Method (Linux Only)
+      description: The driver/mesa version of the installed graphics card.
+      placeholder: e.g. PipeWire/KVM/X11
+    validations:
+      required: false
+  - type: markdown
+    attributes:
+      value: |
+        Make sure to close your issue when it's solved! If you found the solution yourself please comment so that others benefit from it.

From 1b6bf8fa3461f8cf0d8385cb09798ef2cdef171b Mon Sep 17 00:00:00 2001
From: Conn O'Griofa <connogriofa@gmail.com>
Date: Wed, 8 Dec 2021 22:24:49 +0000
Subject: [PATCH 2/2] video: use a better vbv-bufsize & correct software
 bitrate calculation

* Increase vbv-bufsize to 1/10 of requested bitrate. The previous value
  was too low, which was resulting in poor encoding quality and failure to
  stabilize at the requested bitrate. Setting to 1/10 of bitrate is a
  good compromise, as it avoids quality loss but also prevents bandwidth
  spikes far above the bitrate/vbv-maxrate.
* With vbv-bufsize set to a more appropriate value, testing shows that
  the average bitrate vs client-requested bandwidth overshoots by ~20%.
  Adjust for this scenario in the software encoding case only.
---
 sunshine/video.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sunshine/video.cpp b/sunshine/video.cpp
index 84038a6f..1a3d51e9 100644
--- a/sunshine/video.cpp
+++ b/sunshine/video.cpp
@@ -930,9 +930,9 @@ std::optional<session_t> make_session(const encoder_t &encoder, const config_t &
   }
 
   if(video_format[encoder_t::CBR]) {
-    auto bitrate        = config.bitrate * 1000;
+    auto bitrate        = config.bitrate * (hardware ? 1000 : 800); // software bitrate overshoots by ~20%
     ctx->rc_max_rate    = bitrate;
-    ctx->rc_buffer_size = bitrate / config.framerate;
+    ctx->rc_buffer_size = bitrate / 10;
     ctx->bit_rate       = bitrate;
     ctx->rc_min_rate    = bitrate;
   }