RetroArch/input/connect/connect_ps3.c
gblues a4b934b71a
Fix some HID bugs (#14435)
* Fix Sixaxis gamepad operation

== DETAILS
It looks like commit 78e7d23c144c862d65ae1bf7ee41a1228bdfa380 broke
the DualShock. Sorry, @revvv, but this is probably going to break the
Retrode driver. We'll need to figure out a different solution.

* Fix a bunch of HID implementations

== DETAILS
As mentioned in the previous commit, the thing that broke the DS3
driver was a change to the wiiu HID handler, which did some pointer
math on the data buffer.

The thing is.. there's no reason to do that pointer math. Yet, I found
the same thing on almost every other HID driver: OSX, libusb, wiiusb.
The only other HID driver that did not do this was the Bluetooth
HID driver.

It doesn't make any sense. The only reason it doesn't crash is because
the memory right before the buffer is valid memory.

Change summary:
- remove the weird pointer math from all HID controllers
- remove the `#ifdef apple ...` in the ds3 and gamecube adapter
  drivers, because it's no longer needed.
- in the pad packet handlers, decrement data buffer offset references
  to account for the removal of the buffer manipulation.

* Fix DualShock 4

== DETAILS
Should've only subtracted 1, not 2; and now the pad works.

Also, added a PID to cover newer model DS4s. I picked "R2" out of the air
for the constant.

Tested on Mac OS

* Really really fix iohidmanager_set_report

A huge apology to @23rd for insulting your fix. I was wrong to call you
wrong.

That left the question: why did that change break the DS3?

Well, it's because `IOHIDDeviceSetReport` expects the report buffer to be
just the report. All of RA's HID SetReport calls include the report number
in the first byte, so we have to trim that off.

We actually do this in a different invocation of `IOHIDDeviceSetReport`
elsewhere in the file! This commit applies that same logic to
`iohidmanager_set_report`

This has two benefits:

1. The DS3 works
2. The DS3 no longer requres the user to press the PS button to activate
   it the first time. You plug it in and it Just Works, just like on Wii U.
2022-09-26 14:32:49 +02:00

372 lines
10 KiB
C

/* RetroArch - A frontend for libretro.
* Copyright (C) 2013-2014 - Jason Fetters
* Copyright (C) 2011-2017 - Daniel De Matteis
*
* RetroArch is free software: you can redistribute it and/or modify it under the terms
* of the GNU General Public License as published by the Free Software Found-
* ation, either version 3 of the License, or (at your option) any later version.
*
* RetroArch is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;
* without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
* PURPOSE. See the GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along with RetroArch.
* If not, see <http://www.gnu.org/licenses/>.
*/
#include <stdint.h>
#include <string.h>
#include <stdlib.h>
#include <boolean.h>
#include "joypad_connection.h"
#include "../input_defines.h"
#include "../../verbosity.h"
#define DS3_ACTIVATION_REPORT_ID 0xf4
#define SIXAXIS_REPORT_0xF2_SIZE 17
#define SIXAXIS_REPORT_0xF5_SIZE 8
typedef struct ds3_instance
{
hid_driver_t *driver;
void *handle;
int slot;
bool led_set;
uint32_t buttons;
int16_t analog_state[3][2];
uint16_t motors[2];
uint8_t data[64];
} ds3_instance_t;
struct __attribute__((__packed__)) sixaxis_led
{
uint8_t time_enabled; /* the total time the led is active (0xff means forever) */
uint8_t duty_length; /* how long a cycle is in deciseconds (0 means "really fast") */
uint8_t enabled;
uint8_t duty_off; /* % of duty_length the led is off (0xff means 100%) */
uint8_t duty_on; /* % of duty_length the led is on (0xff mean 100%) */
};
struct __attribute__((__packed__)) sixaxis_rumble
{
uint8_t right_duration; /* Right motor duration (0xff means forever) */
uint8_t right_motor_on; /* Right (small) motor on/off, only supports values of 0 or 1 (off/on) */
uint8_t left_duration; /* Left motor duration (0xff means forever) */
uint8_t left_motor_force; /* left (large) motor, supports force values from 0 to 255 */
};
struct __attribute__((__packed__)) sixaxis_output_report
{
uint8_t report_id;
uint8_t padding1;
struct sixaxis_rumble rumble;
uint8_t padding2[4];
uint8_t leds_bitmap; /* bitmap of enabled LEDs: LED_1 = 0x02, LED_2 = 0x04, ... */
struct sixaxis_led led[4]; /* LEDx at (4 - x) */
struct sixaxis_led _reserved; /* LED5, not actually soldered */
uint8_t unknown[13];
};
struct __attribute__((__packed__)) sixaxis_activation_report
{
uint8_t report_id;
uint8_t knock[4];
};
union sixaxis_activation_report_f4
{
uint8_t buf[5];
struct sixaxis_activation_report data;
};
union sixaxis_output_report_01
{
uint8_t buf[49];
struct sixaxis_output_report data;
};
static const union sixaxis_output_report_01 default_report = {
{
0x01, /* report ID */
0x00, /* padding */
0xff, 0x00, /* right rumble */
0xff, 0x00, /* left rumble */
0x00, 0x00, 0x00, 0x00, /* gyro */
0x00, /* LED bitmap */
0xff, 0x27, 0x10, 0x00, 0x32, /* LED 1 config */
0xff, 0x27, 0x10, 0x00, 0x32, /* LED 2 config */
0xff, 0x27, 0x10, 0x00, 0x32, /* LED 3 config */
0xff, 0x27, 0x10, 0x00, 0x32, /* LED 4 config */
0x00, 0x00, 0x00, 0x00, 0x00, /* LED 5 config (unusable/unsoldered) */
0x00, 0x00, 0x00, 0x00, 0x00, /* unknown */
0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00
}
};
static const union sixaxis_activation_report_f4 ds3_activation_packet = {
{ 0xf4, 0x42, 0x0c, 0x00, 0x00 }
};
/* forward declarations */
static int ds3_set_operational(ds3_instance_t *instance)
{
int ret;
uint8_t usb_packet[64] = { 0x00 };
if(instance->driver->set_report == NULL || instance->driver->get_report == NULL) {
RARCH_ERR("This HID implementation does not support the Sony Sixaxis controller:\n");
if(instance->driver->set_report == NULL)
RARCH_ERR("- set_report implementation is missing\n");
if(instance->driver->get_report == NULL)
RARCH_ERR("- get_report implementation is missing\n");
return -1;
}
ret = instance->driver->set_report(instance->handle, HID_REPORT_FEATURE, ds3_activation_packet.data.report_id, ds3_activation_packet.buf, sizeof(ds3_activation_packet.buf));
if (ret < 0) {
RARCH_LOG("Failed to send activation packet\n");
return ret;
}
ret = instance->driver->get_report(instance->handle, HID_REPORT_FEATURE, 0xf2, &usb_packet, SIXAXIS_REPORT_0xF2_SIZE);
if (ret < 0) {
RARCH_LOG("Failed to read feature report 0xf2\n");
return ret;
}
ret = instance->driver->get_report(instance->handle, HID_REPORT_FEATURE, 0xf5, &usb_packet, SIXAXIS_REPORT_0xF5_SIZE);
if (ret < 0) {
RARCH_LOG("Failed to read feature report 0xf5\n");
return ret;
}
return 0;
}
static uint8_t ds3_get_leds(unsigned pad_number)
{
switch(pad_number)
{
case 1:
case 2:
case 3:
case 4:
return 1 << pad_number;
case 5:
return (1 << 1) | (1 << 4);
case 6:
return (1 << 2) | (1 << 4);
case 7:
return (1 << 3) | (1 << 4);
case 8:
return (1 << 3) | (1 << 1) | (1 << 4);
case 9:
return (1 << 2) | (1 << 3) | (1 << 4);
case 10:
default:
break;
}
return (1 << 1) | (1 << 2) | (1 << 3) | (1 << 4);
}
static int ds3_send_output_report(ds3_instance_t *instance)
{
struct sixaxis_output_report report = {0};
uint8_t *packet = (uint8_t *)&report;
/* Initialize the report with default values */
memcpy(&report, &default_report, sizeof(struct sixaxis_output_report));
report.leds_bitmap = ds3_get_leds(instance->slot + 1);
return instance->driver->set_report(instance->handle, HID_REPORT_OUTPUT, report.report_id, packet, sizeof(report));
}
static void ds3_update_pad_state(ds3_instance_t *instance)
{
uint32_t i, pressed_keys;
static const uint32_t button_mapping[17] =
{
RETRO_DEVICE_ID_JOYPAD_SELECT,
RETRO_DEVICE_ID_JOYPAD_L3,
RETRO_DEVICE_ID_JOYPAD_R3,
RETRO_DEVICE_ID_JOYPAD_START,
RETRO_DEVICE_ID_JOYPAD_UP,
RETRO_DEVICE_ID_JOYPAD_RIGHT,
RETRO_DEVICE_ID_JOYPAD_DOWN,
RETRO_DEVICE_ID_JOYPAD_LEFT,
RETRO_DEVICE_ID_JOYPAD_L2,
RETRO_DEVICE_ID_JOYPAD_R2,
RETRO_DEVICE_ID_JOYPAD_L,
RETRO_DEVICE_ID_JOYPAD_R,
RETRO_DEVICE_ID_JOYPAD_X,
RETRO_DEVICE_ID_JOYPAD_A,
RETRO_DEVICE_ID_JOYPAD_B,
RETRO_DEVICE_ID_JOYPAD_Y,
16 /* PS button */
};
instance->buttons = 0;
pressed_keys =
instance->data[2]
| (instance->data[3] << 8)
| ((instance->data[4] & 0x01) << 16);
for (i = 0; i < 17; i++)
instance->buttons |= (pressed_keys & (1 << i)) ?
(1 << button_mapping[i]) : 0;
}
static void ds3_update_analog_state(ds3_instance_t *instance)
{
int pad_axis;
for (pad_axis = 0; pad_axis < 4; pad_axis++)
{
unsigned axis = (pad_axis % 2) ? 0 : 1;
unsigned stick = pad_axis / 2;
int16_t interpolated = instance->data[6 + pad_axis];
/* libretro requires "up" to be negative, so we invert the y axis */
interpolated = axis
? ((interpolated - 128) * 256)
: ((interpolated - 128) * -256);
instance->analog_state[stick][axis] = interpolated;
}
}
static void *ds3_init(void *handle, uint32_t slot, hid_driver_t *driver)
{
ds3_instance_t *instance = (ds3_instance_t *)
calloc(1, sizeof(ds3_instance_t));
if (!instance)
return NULL;
instance->handle = handle;
instance->driver = driver;
instance->slot = slot;
if (instance->driver->set_protocol)
instance->driver->set_protocol(instance->handle, 1);
if (ds3_send_output_report(instance) < 0)
{
RARCH_LOG("Failed to send output report\n");
goto error;
}
if (ds3_set_operational(instance) < 0)
{
RARCH_LOG("Failed to set operational mode\n");
goto error;
}
return instance;
error:
free(instance);
return NULL;
}
static void ds3_deinit(void *device_data)
{
if (device_data)
free(device_data);
}
static void ds3_packet_handler(void *device_data,
uint8_t *packet, uint16_t size)
{
ds3_instance_t *device = (ds3_instance_t *)device_data;
if (!device)
return;
if (!device->led_set)
{
ds3_send_output_report(device);
device->led_set = true;
}
if (size > sizeof(device->data))
{
RARCH_ERR("[ds3]: Expecting packet to be %ld but was %d\n",
(long)sizeof(device->data), size);
return;
}
memcpy(device->data, packet, size);
ds3_update_pad_state(device);
ds3_update_analog_state(device);
}
static void ds3_set_rumble(void *device_data,
enum retro_rumble_effect effect, uint16_t strength)
{
/* TODO/FIXME - implement */
}
static void ds3_get_buttons(void *device_data, input_bits_t *state)
{
ds3_instance_t *device = (ds3_instance_t *)device_data;
if (device)
{
/* copy 32 bits : needed for PS button? */
BITS_COPY32_PTR(state, device->buttons);
}
else
BIT256_CLEAR_ALL_PTR(state);
}
static int16_t ds3_get_axis(void *device_data, unsigned axis)
{
union joyaxis
{
uint32_t encoded;
int16_t axis[2];
} joyaxis;
axis_data axis_data = {0};
ds3_instance_t *device = (ds3_instance_t *)device_data;
joyaxis.encoded = axis;
gamepad_read_axis_data(axis, &axis_data);
if (!device || axis_data.axis >= 4)
return 0;
if (joyaxis.axis[0] < 0 || joyaxis.axis[1] < 0)
return gamepad_get_axis_value(device->analog_state, &axis_data);
return gamepad_get_axis_value_raw(device->analog_state, &axis_data, false);
}
static const char *ds3_get_name(void *device_data)
{
return "PLAYSTATION(R)3 Controller";
}
static int32_t ds3_button(void *device_data, uint16_t joykey)
{
ds3_instance_t *device = (ds3_instance_t *)device_data;
if (!device || joykey > 31)
return 0;
return device->buttons & (1 << joykey);
}
pad_connection_interface_t pad_connection_ps3 = {
ds3_init,
ds3_deinit,
ds3_packet_handler,
ds3_set_rumble,
ds3_get_buttons,
ds3_get_axis,
ds3_get_name,
ds3_button,
false,
};