62 Commits

Author SHA1 Message Date
zoltanvb
1e58df4f51
Flexible thumbnail improvements. (#16082)
- Move flag logic to task_push_pl_entry_thumbnail_download - this
enables individual "download thumbnails" entry to be also flexible
- Add a message when this download has been tried enough times
(i.e. 3)
- Optimize cases when full or short name is the same as standard
name, skip queries if so (both download and local file)
2024-01-07 07:57:39 -08:00
zoltanvb
8886b92455
Thumbnail fixes (#16062)
* Minor thumbnail improvements

- set standard name if only one entry is in the playlist
- use first database name for thumbnails if core has multiple

* Fix playlist thumbnail downloader

Playlist thumbnail downloader function was missed from the flexible
thumbnail name update, now it is added.
2024-01-01 17:23:18 -08:00
zoltanvb
3ce56c5b42
Flexible thumbnail matching (#16040)
Add logic to handle 3 possible thumbnail names, in following order:
- most exact name derived from content file (same name, with .png extension)
- usual name derived from playlist (usually coming from database)
- shortened name up to first bracket, chopping off region/publisher etc. info

For local file system, names are checked always.
For thumbnail downloads, names are checked each time the item comes up
in the playlist, meaning that it may take going back and forth 3 times
for a thumbnail to appear. However, as a positive change, failed thumbnail
downloads are not repeated for the same playlist, which was not the case
earlier.
2023-12-27 02:26:46 -08:00
sonninnos
5533f3881f
Prevent directory creation on bogus thumbnail downloads (#15634) 2023-08-21 23:07:38 -07:00
sonninnos
d5c09b65e0
Don't write bogus thumbnails to disk (#15593) 2023-08-14 17:29:53 -07:00
libretroadmin
7d60a2cc8f Move functions around, make some static, move some around 2023-06-16 03:27:19 +02:00
libretroadmin
f2bb150b0a Get rid of some menu_driver_ctl calls 2023-05-11 05:22:17 +02:00
libretroadmin
01c3684b10 Cleanups - try to remove stdio.h include where possible 2023-01-21 22:25:38 +01:00
Bernhard Schelling
c9bbe7683f
Add View feature (#14467)
* Add View feature
Add saving of a filter set in the Explore menu into a so called "View" file which then gets listed alongside playlists.
This also adds the ability to filter a category by range in the Explore menu and not just filter on exact matches.

* Menu improvements for explore and views

* Collapse ozone sidebar in view

* Fix problems with the sidebar in explore/view

* Ignore view files in the Qt playlists menu

* Add missing semicolon

* Support downloading thumbnails in views
2022-10-10 06:36:02 +02:00
LibretroAdmin
951b98fe1b
Bools to flags (#14486)
* (D3D11) Use flags instead of bools

* (RPNG) Use flags

* Simplify rpng_is_valid

* (rpng_is_valid) Prevent potential NULL pointer dereference
(D3D11) Some whitespacing changes/code nits

* (task_pl_thumbnail_download.c) Simplify some code
2022-10-06 19:26:38 +02:00
LibretroAdmin
30eb0edcf8 Use flags for some structs instead of tons of bools - less state/variables to bookkeep,
less memory used
2022-10-06 06:53:13 +02:00
sonninnos
c4c55077a1
Allow On-Demand Thumbnails in Explore menu (#14385) 2022-09-05 00:01:38 +02:00
LibretroAdmin
b2634ea588 * Create fill_pathname_join_special - and specify fill_pathname_join
as deprecated.
* Use fill_pathname_join_special in the vast majority of cases where
we can ensure out_path is a new empty string
* Get rid of some extension concatenation with strlcat where encountered
* Some general cleanups with NULL termination of strings that get immediately
passed to strlcpy/strlcpy-adjacent functions
2022-08-04 14:19:38 +02:00
libretroadmin
69a2d124c0 Don't do NULL termination on string if we pass it off to strlcpy
and/or a file_path function that uses strlcpy under the hood
2022-07-24 05:39:51 +02:00
LibretroAdmin
29774f5b7a
Small opts (#14186)
* (joypad_connection) Small optimizations -
* Turn functions static where possible
* Hose strlen call out of loop

* (input_driver.c) General cleanups:
* Some small code/style nits

task_screenshot.c:
* Move widget callback function for screenshots to task_screenshot.c

(file_path.c):
* Turn get_pathname_num_slashes into static function
* path_linked_list_free - always returns true, so get rid of return value
* path_linked_list_new - fix function signature
* path_get_archive_delim - do not NULL-terminate string, already done by strlcpy later on

General:
* Slight optimizations - use int/size_t for loop counter variable instead of unsigned
* Take advantage of fact that strlcpy already NULL-terminates, so don't do this explicitly
outside if we're just going to end up calling strlcpy/fill_pathname_join on it anyway
2022-07-19 10:01:33 +02:00
libretroadmin
ad87f88b72 (task_pl_thumbnail_download.c) Minor cleanups/style nits - reducing
return paths
2022-07-09 17:13:26 +02:00
twinaphex
9bcee062ff Cleanups/warnings 2022-03-07 19:32:01 +01:00
twinaphex
7c8c53fb2d Get rid of menu_driver_get_ptr - we are going to be using only one
getter for each component state instead of several getters
2021-09-21 07:14:27 +02:00
twinaphex
544a17926b Use path_basename_nocompression where we are sure we are not
dealing with a filename with a compressed archive hash
2021-04-11 17:44:41 +02:00
twinaphex
ed6dd6d6d1 Fix get_thumbnail_paths 2021-03-29 17:42:32 +02:00
twinaphex
cc8160d044 task_pl_thumbnail_download.c - put char string of 8192 length
on heap for all platforms
2021-03-29 09:28:26 +02:00
Autechre
ba7900a3fb
Merge pull request #12173 from crystalct/master
Some PSL1GHT fixes
2021-03-29 09:26:24 +02:00
CrystalCT
b9ff6cb1d9 Some PSL1GHT fixes 2021-03-29 09:01:03 +02:00
Jamiras
501fe45a9f have http tasks clean up after themselves 2021-03-15 19:42:25 -06:00
twinaphex
4ec216dc0b Get rid of file_path_str 2020-08-22 01:06:10 +02:00
twinaphex
87c0fb6323 Struct reordering 2020-08-14 18:58:09 +02:00
twinaphex
d3b234f404 Buildfix 2020-08-11 09:03:59 +02:00
twinaphex
ac083e69ba Cleanups 2020-08-11 06:46:45 +02:00
twinaphex
d72b118a2d Make char array big enough 2020-07-23 05:21:32 +02:00
twinaphex
408f40f413 Cut down on some callocs 2020-06-27 16:36:08 +02:00
jdgleaver
0fcfb3deda Refactor playlist struct configuration 2020-06-26 15:40:19 +01:00
twinaphex
de36ff20fb Create string_ends_with_size 2020-06-25 14:38:06 +02:00
twinaphex
c31bfb4dc8 (task_pl_thumbnail_download) Simplifications 2020-06-08 21:20:07 +02:00
twinaphex
ce95dcaf79 (task_pl_thumbnail_download) Some string_is__equal optimizations 2020-06-08 07:31:58 +02:00
twinaphex
6cc47f8ee0 task_pl_thumbnail_download - replace many subsequent strlcat calls
with one snprintf
2020-05-29 10:30:56 +02:00
jdgleaver
955e25fc39 (On Demand Thumbnails) Fix heap-use-after-free error 2020-05-22 11:07:34 +01:00
twinaphex
38135c505b Rearrange struct members based on size 2020-03-12 06:59:07 +01:00
twinaphex
32e4aea068 Start making the other code safe that is dependent on menu driver
ident checking
2020-03-04 20:47:39 +01:00
twinaphex
0ef1b342e4 settings Cleanups 2020-03-02 20:10:24 +01:00
twinaphex
f74225721d menu_thumbnail and menu_thumbnail_path now decoupled from menu
system
2020-02-16 16:38:17 +01:00
twinaphex
cd20966fc8 Remove more settings_t dependencies 2020-02-03 08:00:08 +01:00
Jamiras
7325147d83 add task_push_http_transfer_file 2020-01-17 19:48:40 -07:00
jdgleaver
495ad41741 Thumbnail downloader clean-ups 2020-01-10 11:08:36 +00:00
jdgleaver
c356969c3a (GLUI) Add initial thumbnail support 2019-10-31 17:25:55 +00:00
twinaphex
b94b9e2adb Go back to plain strlcpy/strlcat - probably best to look at
opportunities to reduce these calls vs. replacing them with
unsafe macros
2019-09-23 00:19:01 +02:00
twinaphex
3b057d9605 Start using STRLCAT_CONST_INCR and STRLCPY_CONST 2019-09-20 23:33:17 +02:00
twinaphex
ec4bfd7827 Silence some warnings - statement unreachable etc. 2019-09-20 06:17:40 +02:00
twinaphex
db624a7c99 Start cleaning up the rather messy manual assignment 2019-09-20 02:03:26 +02:00
twinaphex
8fa6230426 Cleanups 2019-09-18 02:16:47 +02:00
twinaphex
d01ae6929d Don't use strlcat for basic concatenation of characters
except when absolutely necessary
2019-09-17 02:00:04 +02:00