3308 Commits

Author SHA1 Message Date
twinaphex
d9fa5585a0 Silence static code analysis warings pointed out by cppcheck 2021-03-24 02:23:58 +01:00
twinaphex
8f79e14d0a Silence LGTM static code analysis warnings 2021-03-24 00:25:47 +01:00
twinaphex
0d06927105 Use ARRAY_SIZE where applicable 2021-03-23 17:14:41 +01:00
twinaphex
fdc184c60c input_config_parse_key - unroll 2021-03-23 01:10:14 +01:00
twinaphex
49dc7e6c66 * Fix some DISABLE_MENU issues
* Optimizations to read_keybinds_conf / set_autoconfig_binds -
first fill_pathname_join_delim call always produced the same output and
this was called four times in a row in one loop,  hose out of the
caller functions and move it into the loop and call it once
2021-03-23 01:05:01 +01:00
twinaphex
437a49780c Add another HAVE_MENU ifdef 2021-03-22 22:12:58 +01:00
twinaphex
fb9d8bad74 Fix DISABLE_MENU 2021-03-22 22:03:16 +01:00
twinaphex
4ff2d85a18 Unsafe to leave input_driver_mapper on heap; plus no real need to
have it on heap when it's already on heap courtesy of rarch_state
2021-03-22 21:43:31 +01:00
twinaphex
882fc9bc2c Simplify config_read_keybinds/save_keybinds 2021-03-22 00:24:00 +01:00
twinaphex
a204bcbf81 Simplify input_config_get_prefix 2021-03-21 23:26:06 +01:00
twinaphex
e5ca68a518 Simplify video_driver_get_ptr 2021-03-21 17:33:44 +01:00
twinaphex
26ea20905a (retroarch.c) Get rid of two config_get_ptr calls 2021-03-21 17:18:37 +01:00
twinaphex
8b2eb8ed37 Cut down on config_get_ptr calls in menu_displaylist_ctl 2021-03-21 16:36:36 +01:00
twinaphex
a83af11754 remove unused variable 2021-03-20 17:47:44 +01:00
twinaphex
94ae0460cc Cut down on calls to gfx_display_get_fb_size 2021-03-20 16:52:53 +01:00
twinaphex
f1330f3c98 (video_thread_wrapper) Call video_driver_get_data instead of
video_driver_get_ptr - last parameter passed to video_driver_get_ptr
was hardcoded
2021-03-20 15:15:52 +01:00
twinaphex
76c4f12089 Cleanup some VIDEO_DRIVER_GET_PTR_INTERNAL calls 2021-03-20 15:15:52 +01:00
twinaphex
9fd88744ff Get rid of menu_input_reset 2021-03-20 15:15:52 +01:00
twinaphex
78fcdc1a46 Cleanups - don't go through some small wrapper functions 2021-03-20 13:51:56 +01:00
twinaphex
37a4dfb9db Don't call some one-line wrapper functions 2021-03-20 13:46:57 +01:00
twinaphex
b51bb2bc66 Simplify parse_hat function 2021-03-20 13:24:10 +01:00
twinaphex
83a1e9170d Simplify retroarch_load_shader_preset 2021-03-19 12:31:13 +01:00
twinaphex
5ac7a524a2 Further refinement to vrr_runloop_enable checks surrounding
audio_driver_monitor_adjust_system_rates
2021-03-19 10:28:11 +01:00
twinaphex
4806a34920 Cleanups in adjust_system_rates functions 2021-03-18 20:38:26 +01:00
twinaphex
5554e5a842 Small cleanups 2021-03-18 12:51:17 +01:00
sonninnos
4ff2011e02 Duplicate key event blocking additions 2021-03-17 21:22:46 +02:00
Autechre
e62aabea95
Merge pull request #12157 from Jamiras/task_http_cleanup
have http tasks clean up after themselves
2021-03-16 09:06:58 +01:00
Jamiras
501fe45a9f have http tasks clean up after themselves 2021-03-15 19:42:25 -06:00
twinaphex
b52577aac1 Cleanups 2021-03-15 06:52:16 +01:00
twinaphex
6687920c1d Get rid of some typedefs 2021-03-15 06:37:21 +01:00
Autechre
a4836bbb17
Fix analog triggers (#12151)
* Restore RETRO_DEVICE_ANALOG code while making less changes

* * When input_remap_binds_enable is true, input_driver_mapper is always
allocated and initialized - no need to NULL check
* Get rid of input_remote local variable for network gamepad code
2021-03-15 01:32:56 +01:00
twinaphex
e3b856dcf2 Avoid two consecutive for loops if block_libretro_input is not
enabled
2021-03-14 06:22:07 +01:00
twinaphex
e1b19d2133 Cleanups 2021-03-14 06:15:38 +01:00
twinaphex
bb5c168726 Revert "Create specialized versions of input_state_mask"
- will require more work to properly optimize

This reverts commit bca73b0a469756169cb49b2e4e30a5e930786f1c.
2021-03-14 06:06:28 +01:00
twinaphex
bca73b0a46 Create specialized versions of input_state_mask 2021-03-14 05:47:30 +01:00
twinaphex
4fc1774901 Cleanups 2021-03-14 05:29:40 +01:00
twinaphex
dbe620db60 Cleanups 2021-03-14 02:11:36 +01:00
twinaphex
4946d75c3d Further cleanups to do with menu_dialog code 2021-03-12 11:03:57 +01:00
twinaphex
53b4fe7716 This ifdef is no longer needed, remove - also 'push'
was always true so just hardcode it for this function
2021-03-12 10:57:42 +01:00
Autechre
de67a13ab9
Merge pull request #12134 from yoshisuga/macos_support_assets_bundle_extraction
[macOS] Support bundle assets extraction for macOS; Fix default paths
2021-03-12 10:27:22 +01:00
Yoshi Sugawara
a142f3b852 Support bundle assets extraction for macOS; Fix to only extract assets once on first install; Change cores, assets, other directories to default to application support directory instead of app bundle 2021-03-11 23:12:52 -10:00
twinaphex
4d3f8c3c80 Cleanup 2021-03-12 01:56:59 +01:00
twinaphex
f7f6f3c5d5 Revert "Cleanups - don't call MENU_ENTRIES_CTL_SET_REFRESH in a loop - set it"
This reverts commit ee06ddfbc067f050c7a491984c6dc29f2cfae8e0.
2021-03-11 22:32:28 +01:00
twinaphex
ee06ddfbc0 Cleanups - don't call MENU_ENTRIES_CTL_SET_REFRESH in a loop - set it
once outside
2021-03-11 22:17:38 +01:00
twinaphex
14248f7401 (Menu) Iterate function callback was never used, remove it
- Also turn menu_driver_iterate into static function and
redesign code a bit; non-functional
2021-03-11 20:17:22 +01:00
twinaphex
4d93ac3870 Get rid of menu_setting_ctl 2021-03-11 08:38:53 +01:00
twinaphex
ba7771fd28 MENU_NAVIGATION_CTL_{INCREMENT/DECREMENT/ASCEND_ALPHABET/DESCEND_ALPHABET'
can all be removed now and inlined
2021-03-11 06:23:29 +01:00
twinaphex
6a68cefe60 Cleanups 2021-03-11 05:25:37 +01:00
twinaphex
3c7419bac7 (Menu) Can now get rid of TODO/FIXME 2021-03-11 05:17:32 +01:00
twinaphex
b9d28ea76d Cleanups 2021-03-11 05:14:07 +01:00